Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lens_cosmo.py #273

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jasonwu224
Copy link

No description provided.

Copy link
Collaborator

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the functions to the LensCosmo() class.
Aside from the comments made in the code, can you:

  • add test functions for both new routines here: https://github.com/sibirrer/lenstronomy/blob/main/test/test_Cosmo/test_lens_cosmo.py
  • can you merge this branch on your side with the branch of your other pull request? It's better to have one single pull request. Every time you update the branch that you made a pull request with, it automatically updates the pull request. In that way we can keep track of the comments and updates and have everything together and I can accept and merge all changes at once.
  • add your name and GitHub username to the AUTHORS.rst file

lenstronomy/Cosmo/lens_cosmo.py Outdated Show resolved Hide resolved
lenstronomy/Cosmo/lens_cosmo.py Outdated Show resolved Hide resolved
lenstronomy/Cosmo/lens_cosmo.py Show resolved Hide resolved
lenstronomy/Cosmo/lens_cosmo.py Outdated Show resolved Hide resolved
lenstronomy/Cosmo/lens_cosmo.py Outdated Show resolved Hide resolved
lenstronomy/Cosmo/lens_cosmo.py Show resolved Hide resolved
Copy link
Collaborator

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great! I have a minor comment about using pre-computed conversion factors. Let me know if you have troubles with the test functions!

lenstronomy/Cosmo/lens_cosmo.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants