-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bifrost.memory
's understanding of memory spaces
#223
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 68.19% 68.19% -0.01%
==========================================
Files 65 65
Lines 5515 5486 -29
==========================================
- Hits 3761 3741 -20
+ Misses 1754 1745 -9 ☔ View full report in Codecov by Sentry. |
These test failures might be related to #220. |
It looks like these failures (and some of those part of the testing for #166) are related to missing file(s) needed by the extended |
I did one more check through code to see if I could find any lingering calls to |
This PR updates the "memset" and "memcpy" functions inbifrost.memory
to work withndarray
s that live in non-system accessible spaces.This PR removes the deprecated
memcpy
andmemset
functions frombifrost.memory
.