Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bifrost.memory's understanding of memory spaces #223

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jaycedowell
Copy link
Collaborator

@jaycedowell jaycedowell commented Sep 6, 2023

This PR updates the "memset" and "memcpy" functions in bifrost.memory to work with ndarrays that live in non-system accessible spaces.

This PR removes the deprecated memcpy and memset functions from bifrost.memory.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.19%. Comparing base (898e4a8) to head (98ccc58).
Report is 13 commits behind head on master.

❗ Current head 98ccc58 differs from pull request most recent head f9ae42b. Consider uploading reports for the commit f9ae42b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   68.19%   68.19%   -0.01%     
==========================================
  Files          65       65              
  Lines        5515     5486      -29     
==========================================
- Hits         3761     3741      -20     
+ Misses       1754     1745       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaycedowell
Copy link
Collaborator Author

These test failures might be related to #220.

@jaycedowell
Copy link
Collaborator Author

It looks like these failures (and some of those part of the testing for #166) are related to missing file(s) needed by the extended testbench tests. Maybe we should drop those tests?

@jaycedowell
Copy link
Collaborator Author

I did one more check through code to see if I could find any lingering calls to bifrost.memory.memcpy* or bifrost.memory.memset*. Looks clean. I think this one is ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant