update of Indian calendar 2024 #1929
Conversation
| // Republic Day | ||
| || (d == 26 && m == January) |
There was a problem hiding this comment.
Hi,
I'm not sure all of these need to be added as they duplicate the base holiday logic at the top:
I find it adds complexity here. Without adding them, we are already seeing correct holidays for 2023 and 2024, excluding the Muharrem holiday in July this year, as listed here: https://www.nseindia.com/resources/exchange-communication-holidays. If BBG's INR calendar is different, perhaps we could do with adding another market in the enum within this class? I.e. one to match NSE's holidays (NT calendar in BBG, the current source for this implementation), and one to match RBI's calendar (RB in BBG), as they seem to differ in some years.
There was a problem hiding this comment.
Would that correspond to "Trading holidays" and "Clearing holidays" at https://www.nseindia.com/resources/exchange-communication-holidays?
There was a problem hiding this comment.
That may be the case. I'll gladly help verify when I have access to Bloomberg again after the holidays.
I still hope that we could simplify the logic, dropping those already covered by the standard annual holidays and some others that fall on weekends in 2024:
Would it should suffice to only mention them in the comments for 2024?
There is also a recent announcement for an election holiday in May: https://www.livemint.com/market/stock-market-news/lok-sabha-elections-2024-indian-bourses-likely-to-remain-shut-on-polling-day-in-mumbai-11710637030326.html. This can probably be added as well. 🙂
There was a problem hiding this comment.
Hi again,
I finally got down to reviewing the calendars.
I found one historical occasion where the RBI (Mumbai branch) differed from the NSE (clearing holidays). E.g. 2022-02-07 was a holiday in the former, though not the latter. This caused some turmoil, apparently.
Unless there are objections, I'd be happy to incorporate the improvements from this PR in a new PR, with proper attributions of course. Then I can also get the election holiday (2024-05-20) added. Would that be ok with you?
There was a problem hiding this comment.
Thank you. Unfortunately, I have not had time to look in that. Feel free to do so.
compared to Bloomberg INR swap calendar.