New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Float2Fixed converter [Originally PR #399] #666
Open
mgkwill
wants to merge
31
commits into
main
Choose a base branch
from
f2f_conv
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 3a71b6a33f3ce4433a6f1f64572062c35fe46720 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Thu Oct 6 06:36:42 2022 -0700 Rerun tutorial commit d4a9510b9d2589b389a523cc01b6bb794fe70596 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Thu Oct 6 06:35:55 2022 -0700 Update precision and rerun commit 20e50439d92453e7f6c26223991d0c5050aae6ef Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Oct 5 15:29:18 2022 -0700 Extend tutorial commit d78da5f6154971928ebe7da51104912b7435d2e0 Merge: 992b7c8 a397960 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Oct 5 12:41:42 2022 -0700 Merge branch 'dev/float2fixed_hier_proc' into dev/float2fixed_converter commit 992b7c837bf51c43fd4697cd0f57c5aac0b6c8a7 Merge: 6d436bd 41f56f0 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Oct 5 12:41:00 2022 -0700 Merge remote-tracking branch 'upstream/main' into dev/float2fixed_converter commit a39796058827519d0e4e6c9f5137eb36cbf06d3f Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Oct 5 12:40:20 2022 -0700 Update EI tutorial commit 51b6e6a12ecfac111b07557c18e4b6becf84b764 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Oct 5 12:36:24 2022 -0700 Increase test coverage, add documentation commit 169f51a5b643c5e07c957198d41ed2b9ac143baf Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Oct 5 08:29:01 2022 -0700 Get rid of debugging prints commit b6eb91285c6d89dcd5c62f4c58f77855e69c8e5f Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Oct 5 08:25:20 2022 -0700 Adapt end_to_end tutorial 2 to for converter commit 638ca64c48dc662a4a09adab9bdd4b7e55174411 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Oct 5 08:24:08 2022 -0700 Change LIF Proc to run it with converter commit 9cc9bd719a284a9899297b679ef1156a010b05c0 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Oct 5 08:22:30 2022 -0700 Add support of hierarchical Processes commit 1355109e24ee54bd7acf6de3849ec33dda62931d Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Tue Oct 4 06:01:35 2022 -0700 WIP implementing support for hierarchical proc commit 6d436bd2c1875b4849ac15ac3d94ae8aa4119429 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Mon Oct 3 08:24:34 2022 -0700 Update f2f conversion example commit 1fe4fd73d21f708f1d54b3dd2c2187e5e72ea0ec Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 30 09:55:17 2022 -0700 Clean up f2f converter and tests commit 18ceae2a4c385e245257d3221988da226612f7ff Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 30 09:40:47 2022 -0700 Add first simple f2f conversion tutorial commit 4ba62526ade9a52c47291de8630279268d0a0e3b Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 30 09:39:54 2022 -0700 Example changes for LIF/Dense commit f3bd9e4e71288cb5e892813934f20b43cd95c43f Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 30 05:47:30 2022 -0700 Mant Exp Separation commit d60d5dca297b2fcd5bdc7e64626ed63dea7ae5aa Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 30 03:52:51 2022 -0700 Make Unittest pass commit 78ea270a1e0f3f2014af8f39fc46d5e21243f598 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Thu Sep 29 02:48:22 2022 -0700 Add support for RefPorts commit 17dccdeee9272bb023678a28229baa7960b11b57 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Sep 28 07:06:52 2022 -0700 Remove unused InPort items, make code more flexible to deal with RefPorts commit 0eb3a6b288d66365af9e46d8ac59d3fcfa0abcdd Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Sep 28 05:22:51 2022 -0700 WIP: Correct LIF and Dense update to new precision format commit 4d6371f293557760815bb12a5a8347abb08e17c5 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Sep 28 05:19:41 2022 -0700 Add reducing dynamic range via quantiles commit 8dbe6aa0106cb28b22fc546b98bd0a23b5a5ef2d Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Tue Sep 27 10:56:24 2022 -0700 Add tests for more descriptive errors and fixed error in setting domain commit 76c0c384761bd706488e79a3ceef21c55f3cfa08 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Tue Sep 27 07:23:41 2022 -0700 WIP: Adapt procs to new precision format commit af47b90a2810e565c4fc4104d82f32e58a1b380d Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Tue Sep 27 07:22:21 2022 -0700 Make error when precision provided incorrectly more telling commit 53027f04129ab3e68fcc9524bd1bec8d99a1d273 Merge: ce72fa9 fe0812f Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Tue Sep 27 05:52:52 2022 -0700 Merge branch 'main' into dev/float2fixed_converter commit ce72fa939db15913d533458f0747d475effa8577 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Tue Sep 27 05:52:07 2022 -0700 Implement convert function commit 3a6f3a76f67196d9cbeb257e69febc4f99ab84b6 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Tue Sep 27 03:35:04 2022 -0700 Add functionality to scale parameters commit 55b7fb83d54b23bd6506a4adde37f2eda4033725 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Tue Sep 27 00:57:09 2022 -0700 Add functionality to determine slope of scaling for f2f conversion commit 55865b29293a26e479f34b967f4f9d1bc82b68d0 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Mon Sep 26 06:36:56 2022 -0700 Add constructing scale domain dict for conversion commit df3a4873a8820b3f227940ac32da78cd7b0da8cc Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Mon Sep 26 04:47:10 2022 -0700 Improve comment for LavaPyType commit 6950048bc3e657639744b3da306770d3da35f9c5 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Mon Sep 26 02:45:52 2022 -0700 Amend LavaPyType with scale_domain commit 292011f89e5e3f69291bef6909b9f6b86da2e0e2 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Sat Sep 24 16:34:16 2022 -0700 Add running procs and getting monitored data commit 7ded2862349079ab18c0cd9523d5faabbee20a14 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Sat Sep 24 08:50:52 2022 -0700 Add monitoring infrastructure commit 3cf7d27c9a86d5356710f19813a0c92acbc569a0 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 23 07:09:12 2022 -0700 Update and consistency of implicit shifts commit fadc85b9e195481d587339d0efa2f76440574f94 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 23 04:51:39 2022 -0700 Change dictionary containing conversion data and adapt tests commit 5a949f31eadceb42ac103b195246e9c329ef18a2 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 23 00:33:45 2022 -0700 WIP: Consistency of implicit shifts commit b52550bc01fc4020bf0c98151508e3a549f1e6bf Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 9 06:24:38 2022 -0700 Fix format commit 821daffbc70882032b3063d103622fb98a795725 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 9 04:10:46 2022 -0700 Get warnings right in LavaPyType, update tests for Float2Fixed Converter commit 8206de1e4d000451551b983f2acea9d52ee9ca0c Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 9 03:54:22 2022 -0700 Modify LavaPyType and add test, adapt Float2Fixed Converter and tests commit f5282986cf07c64ec726d41e5ab57105452892cc Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Thu Sep 8 05:39:03 2022 -0700 Add _get_fixed_pt_proc_models to Float2FixedPoint converter commit aae46677b58daae7c4607aa706e566d2b6bd9b38 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Thu Sep 8 04:54:38 2022 -0700 Add _get_var_ports to Float2FixedPoint converter commit c673464b7268168afb9ed5e2ca733eabaae7c288 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Thu Sep 8 02:52:54 2022 -0700 Add test for _set_procs commit 3b972d51a5878ed881207eb61b0bca8982526aa5 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Thu Sep 8 02:47:43 2022 -0700 Add _set_proc to Float2Fixed converter commit f214762ff0767e24e878df48e652ca05b203faba Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Thu Sep 8 02:33:31 2022 -0700 Add set_run_cfg to converter commit 9fe5d6752758fae35c52d34ec75df463b9a0ffdb Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Thu Sep 8 01:35:42 2022 -0700 Update LavaPyType commit a78c7056830ee3a052eb71f780c75c516493f10b Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 2 04:50:15 2022 -0700 Formatting commit e79a2885d06e5955c5a57259e3df788a939d89d5 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 2 04:40:05 2022 -0700 Add Procs and ProcModels to test for Float2FixedConverter commit 894dac629cb33a094594295d7ffbd9de59323f32 Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Fri Sep 2 02:27:03 2022 -0700 Amend LavaPyType commit 67528838a4a0a6771ff1d1f14eb9345ced80354a Author: ackurth-nc <anno.christopher.kurth@intel.com> Date: Wed Aug 31 07:59:06 2022 -0700 First tests float2fixed converter
…errors. Add respective tests.
added unittest skip for three factor learning tutorial - tutorials as unittests only run on linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #398
Objective of pull request: Add tool performing automated floating- to fixed-point conversion.
Most of the work is from @ackurth-nc in #399, this PR is just to finish up and get it merged to Lava.