Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Update js-draw to version 1.20.2 #10438

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented May 16, 2024

Summary

This pull request updates js-draw from v1.16.1 to v1.20.0.

Among other changes, this adds a partial stroke eraser, a new pen type, and the ability to select multiple pictures in the image tool's file picker (originally implemented as a way to add PDF import on desktop).

See all commits.

Testing plan

This pull request has been manually tested on Android 13 by:

  1. Creating a new note,
  2. Attaching a drawing to the note,
  3. Attaching an image to the drawing,
  4. Writing on the drawing with a stylus,
  5. Zooming in with touch,
  6. Saving the drawing.

Along with performance improvements, this works around the lack of a scroll indicator on Android.
@personalizedrefrigerator personalizedrefrigerator changed the title Mobile: Update js-draw to version 1.19.1 Mobile: Update js-draw to version 1.20.0 May 17, 2024
@personalizedrefrigerator
Copy link
Collaborator Author

I'm temporarily converting this to a draft — while testing, I found an image description-related regression that I would like to release fix for.

@personalizedrefrigerator personalizedrefrigerator marked this pull request as draft May 19, 2024 23:55
@personalizedrefrigerator personalizedrefrigerator marked this pull request as ready for review May 20, 2024 15:10
@personalizedrefrigerator personalizedrefrigerator changed the title Mobile: Update js-draw to version 1.20.0 Mobile: Update js-draw to version 1.20.2 May 20, 2024
@laurent22
Copy link
Owner

There are conflicts after a recent merge

@laurent22 laurent22 merged commit 1e085ee into laurent22:dev May 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants