[11.x] Improves errors #51261
Draft
[11.x] Improves errors #51261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4598691.
src/Illuminate/Foundation/resources/exceptions/renderer/components/card.blade.php
Show resolved
Hide resolved
marius-mcp
reviewed
May 10, 2024
| $events->listen(QueryExecuted::class, [$this, 'onQueryExecuted']); | ||
|
|
||
| if (isset($_SERVER['LARAVEL_OCTANE'])) { | ||
| $events->listen([RequestReceived::class, TaskReceived::class, TickReceived::class, RequestTerminated::class], function () { |
There was a problem hiding this comment.
@nunomaduro does this need to also reset on any job events?
|
@nunomaduro I think this is good pending those weird HTML formatting things I pointed out and single comment above. |
| * | ||
| * @return void | ||
| */ | ||
| protected function regsiterExceptionRenderer() |
There was a problem hiding this comment.
Regsiter ➡️ Register
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.