-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qiskit runtime support #6
Open
ejwilson3
wants to merge
6
commits into
lanl:master
Choose a base branch
from
ejwilson3:dev2
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the failure on mixing backend types starting at line 133 of qiskit.py. |
spakin
reviewed
Dec 6, 2023
raise ValueError('Qiskit Runtime Backend %s supplied without ' | ||
'corresponding Qiskit Runtime Service object.' | ||
'Please resubmit as a Runtime Sampler or' | ||
'include a Service' % repr(backend) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SyntaxError: '(' was never closed
spakin
reviewed
Dec 6, 2023
if runtime_service: | ||
backend, options = _establish_runtime_backend(backend, runtime_service) | ||
else: | ||
sampler = _construct_backendsampler(backend, job_tags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnboundLocalError: local variable 'job_tags' referenced before assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds runtime session option to get results that only have to wait in the queue once.
Things to note:
When using runtime, result.qubits and result.depth will always report 0, as the runtime sampler does not store circuits like the backendsampler does.
Sending a runtime backend into the solver when not using the runtime option, it will change it into a provider backend for the backendsampler instead of creating a runtime sampler.
Had a weird issue with commits; if we're trying to keep the commit history especially clean I can see if I can go back and mess around with them.