Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced buildFrom by build to permit chaining calls #1406

Merged
merged 1 commit into from
May 21, 2024

Conversation

rolalaro
Copy link

Made buildFrom deprecated and replaced it by build, which retu…rns a reference of the object using the method

…rns a reference of the object using the method
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 49.44444% with 273 lines in your changes are missing coverage. Please review.

Project coverage is 45.82%. Comparing base (632b536) to head (cf177ab).
Report is 6 commits behind head on master.

Files Patch % Lines
modules/robot/src/real-robot/viper/vpViper.cpp 0.00% 27 Missing ⚠️
modules/robot/src/real-robot/afma4/vpAfma4.cpp 0.00% 13 Missing ⚠️
...t/src/wireframe-simulator/vpWireFrameSimulator.cpp 35.00% 13 Missing ⚠️
...ore/src/math/transformation/vpForceTwistMatrix.cpp 25.00% 12 Missing ⚠️
...re/src/math/transformation/vpHomogeneousMatrix.cpp 59.09% 9 Missing ⚠️
.../src/math/transformation/vpVelocityTwistMatrix.cpp 47.05% 9 Missing ⚠️
...ules/core/src/math/transformation/vpRzyxVector.cpp 42.85% 8 Missing ⚠️
...ules/core/src/math/transformation/vpRzyzVector.cpp 52.94% 8 Missing ⚠️
...es/core/src/math/transformation/vpThetaUVector.cpp 72.41% 8 Missing ⚠️
.../vision/src/homography-estimation/vpHomography.cpp 38.46% 8 Missing ⚠️
... and 64 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1406      +/-   ##
==========================================
- Coverage   45.85%   45.82%   -0.03%     
==========================================
  Files        1071     1071              
  Lines      108360   108415      +55     
  Branches    18730    18718      -12     
==========================================
+ Hits        49684    49686       +2     
- Misses      58676    58729      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit 5f57401 into lagadic:master May 21, 2024
73 of 75 checks passed
@rolalaro rolalaro deleted the feat_build_from branch May 21, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants