Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error related to GUI #1405

Merged
merged 5 commits into from
May 21, 2024

Conversation

rolalaro
Copy link

  • Added a vpDisplayFactory namespace that permits to either get a newly allocated vpDisplay* if a GUI library is available or a nullptr otherwise. It permits to check only VISP_HAVE_DISPLAY instead of several macro in a software to get a new display.
  • Fix compilation errors when no GUI library is available

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 45.84%. Comparing base (632b536) to head (41d8d3b).
Report is 6 commits behind head on master.

Files Patch % Lines
...l/robot/mbot/raspberry/visp/mbot-apriltag-ibvs.cpp 0.00% 14 Missing ⚠️
...l/robot/mbot/raspberry/visp/mbot-apriltag-pbvs.cpp 0.00% 13 Missing ⚠️
tutorial/image/tutorial-draw-circle.cpp 0.00% 10 Missing ⚠️
tutorial/grabber/tutorial-video-reader.cpp 0.00% 9 Missing ⚠️
tutorial/grabber/tutorial-grabber-1394-writer.cpp 0.00% 7 Missing ⚠️
modules/gui/include/visp3/gui/vpDisplayFactory.h 0.00% 6 Missing ⚠️
tutorial/grabber/tutorial-video-recorder.cpp 0.00% 6 Missing ⚠️
...ial/robot/mbot/raspberry/visp/test-serial-mbot.cpp 0.00% 6 Missing ⚠️
...utorial/grabber/tutorial-grabber-v4l2-threaded.cpp 0.00% 2 Missing ⚠️
tutorial/image/tutorial-draw-cross.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1405      +/-   ##
==========================================
- Coverage   45.85%   45.84%   -0.01%     
==========================================
  Files        1071     1072       +1     
  Lines      108360   108377      +17     
  Branches    18730    18728       -2     
==========================================
- Hits        49684    49683       -1     
- Misses      58676    58694      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit 1ffc3d9 into lagadic:master May 21, 2024
73 of 75 checks passed
@rolalaro rolalaro deleted the fix_nogui_compil branch May 21, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants