Python build improvements #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1316 +/- ##
==========================================
- Coverage 52.83% 52.83% -0.01%
==========================================
Files 410 411 +1
Lines 52734 52739 +5
==========================================
Hits 27863 27863
- Misses 24871 24876 +5 ☔ View full report in Codecov by Sentry. |
…some issues with a base conda environment
… and status logging
A JSON report has been written to C:\visp-ws\test-pr\visp-SamFlt\visp-build-vc17-bindings\modules\python\bindings\logs\sensor_log.json ================================================== main() File "C:\visp-ws\test-pr\visp-SamFlt\venv\Lib\site-packages\visp_python_bindgen\generator.py", line 174, in main generate_module(generation_path_src, config_path) File "C:\visp-ws\test-pr\visp-SamFlt\venv\Lib\site-packages\visp_python_bindgen\generator.py", line 135, in generate_module submodule.generate() File "C:\visp-ws\test-pr\visp-SamFlt\venv\Lib\site-packages\visp_python_bindgen\submodule.py", line 154, in generate submodule_file.write(format_str) File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.12_3.12.496.0_x64__qbz5n2kfra8p0\Lib\encodings\cp1252.py", line 19, in encode return codecs.charmap_encode(input,self.errors,encoding_table) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ UnicodeEncodeError: 'charmap' codec can't encode character '\u03bc' in position 103050: character maps to <undefined> C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(254,5): error MSB8066: la build personnalisée de 'C:\visp-ws\test-pr\visp-SamFlt\visp-build-vc17-bindings\CMakeFi les\27022cb80d68de409fb9a1f1267a3ac9\main.cpp.rule;C:\visp-ws\test-pr\visp-SamFlt\visp-build-vc17-bindings\CMakeFiles\d25447ac6822ec56b31dd8ed2c1fdf26\visp_python_bindings_generator_run.rule' s'est arrêtée. Code 1. [C:\visp -ws\test-pr\visp-SamFlt\visp-build-vc17-bindings\modules\python\visp_python_bindings_generator_run.vcxproj]
…eaders in Python bindings
…leanup log error in python bind gen
…to python_build_improvements
…r code migrated to cpp file, trying to build visp python dll with public interface
…to python_build_improvements
… Joris Vaillant !
…t of json configuration
usage C:\visp-ws\visp\modules\core\include\visp3\core\vpImageTools.h(1589,31): error C2666: 'vpImageTools ::lerp' : les fonctions surchargées ont des conversions similaires. [C:\visp-ws\visp-build-bindings-vc17\modules\python\bindings\_visp.vcxproj]
… and importing directly means that the bindings __init__.py should always be executed, even when generating stubs
|
You did a really great job, thanks a lot !!! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings several small improvements to the Python wrapper build step
make. Thus, to build the python bindings, one should callmake visp_python_bindingsvpAROgre: this would require to fully wrap the OGRE classes, and generates some error at compile time