馃 Bump RDKit version to Release_2024_03_2 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aelgasser
reviewed
May 29, 2024
| @@ -152,7 +152,7 @@ def build_rdkit(self, ext): | |||
| # Start build process | |||
| os.chdir(str("rdkit")) | |||
|
|
|||
| if rdkit_tag == "Release_2023_09_6": | |||
| if rdkit_tag = "Release_2024_03_2" | |||
There was a problem hiding this comment.
@kuelumbus it seems that the github action introduced a typo here (removed an = and the : at the end which prevents the build from working
There was a problem hiding this comment.
Thank for finding this. I think this is fixed in the new master branch already. However, I haven't looked at this PR because the RDKit releases are currently blocked by pypi/support#3962.
There was a problem hiding this comment.
Oh I didn't see that part :(
Hope they'll resolve it soon.
Thanks for the reply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New RDKit version tag detected in https://github.com/rdkit/rdkit.