Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Clean-up storage specific functions in tests/utils.go #11946

Closed

Conversation

alromeros
Copy link
Contributor

What this PR does

This PR aims to clean-up most of the storage-specific functions in tests/utils.go, so we move the logic to the specific tests instead of branching the setup.

In progress. Want to clean-up the commits a bit.

Fixes #

Release note

NONE

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 20, 2024
@alromeros
Copy link
Contributor Author

/test all

@kubevirt-bot kubevirt-bot added sig/buildsystem Denotes an issue or PR that relates to changes in the build system. sig/storage size/XL labels May 20, 2024
Signed-off-by: Alvaro Romero <alromero@redhat.com>
@alromeros alromeros force-pushed the refactor-test-utils-storage branch from d69f648 to 8bac51c Compare May 20, 2024 19:24
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 0xfelix, kbidarkar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot
Copy link
Contributor

@alromeros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations 8bac51c link true /test pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations
pull-kubevirt-e2e-k8s-1.30-sig-storage 8bac51c link true /test pull-kubevirt-e2e-k8s-1.30-sig-storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alromeros
Copy link
Contributor Author

Opening a new PR to arrange the commits a bit better.

@alromeros alromeros closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/virtctl dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. sig/buildsystem Denotes an issue or PR that relates to changes in the build system. sig/storage size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants