-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a metric that reports the VMI last connection timestamp #11934
Conversation
Skipping CI for Draft Pull Request. |
e0468a9
to
12fcf0f
Compare
faa17b4
to
804264c
Compare
/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring |
/cc |
4e96751
to
1bb6eaa
Compare
1bb6eaa
to
f1d47d2
Compare
d83e554
to
81cce4e
Compare
docs/metrics.md
Outdated
@@ -114,6 +114,9 @@ Total VM filesystem capacity in bytes. Type: Gauge. | |||
### kubevirt_vmi_filesystem_used_bytes | |||
Used VM filesystem capacity in bytes. Type: Gauge. | |||
|
|||
### kubevirt_vmi_last_connection_timestamp_seconds | |||
Virtual Machine Instance last connection timestamp, including VNC, console, portforward, SSH and usbredir connections. Type: Gauge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that might be a little misleading. What about connections to VNC/SSH/RDP via a service or secondary interface? As it stands, this would indicate an unused VMI, although it could be accessed via the aforementioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Please see https://github.com/kubevirt/kubevirt/pull/11934/files#r1618522817.
81cce4e
to
d998261
Compare
d998261
to
5624fe4
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks
Bump metrics name linter to v0.0.6 Signed-off-by: assafad <aadmi@redhat.com>
5624fe4
to
d20c733
Compare
f55f3fd
to
ee71e7d
Compare
Add kubevirt_vmi_last_connection_timestamp_seconds metric, which reports the last connection timestamp per VMI. Signed-off-by: assafad <aadmi@redhat.com>
ee71e7d
to
d21cdd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@assafad Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Required labels detected, running phase 2 presubmits: |
/retest-required |
1 similar comment
/retest-required |
@assafad: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does
Add
kubevirt_vmi_last_api_connection_timestamp_seconds
metric, which reports the last connection timestamp per VMI. Connections covered: console, vnc, usbredir, portforward and SSH.Fixes https://issues.redhat.com/browse/CNV-14659
Why we need it and why it was done in this way
This metric will help users to identify VMs that have not been logged into for a long time and have allocated resources but are not actually being used.
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note