Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tests for Printer package. #1093

Merged
merged 1 commit into from
May 22, 2024
Merged

Added Tests for Printer package. #1093

merged 1 commit into from
May 22, 2024

Conversation

joeyyy09
Copy link
Contributor

@joeyyy09 joeyyy09 commented May 19, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

New tests are added to the printer package.

Added test cases for the following functions/tests:

  • TestWriteErrorPropagation
  • TestWriteWithEmptyColumns
  • TestWriteEmptyRow
  • TestWriteMultipleRows
  • TestWriteSingleRow

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 19, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @joeyyy09. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joeyyy09 joeyyy09 changed the title Added Tests for Printer package Added Tests for Printer package. May 19, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 19, 2024
@netlify Netlify
Copy link

netlify bot commented May 19, 2024 •
edited

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 9f5235f
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/664b2ed4d22d55000857f1ee

wzshiming
wzshiming reviewed May 20, 2024
View reviewed changes
pkg/utils/printers/table_printer_test.go Outdated
}

// TestWriteMultipleRows tests writing multiple rows.
func TestWriteMultipleRows(t *testing.T) {
Copy link
Member

@wzshiming wzshiming May 20, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is repeated with TestWriteRows

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 20, 2024
@joeyyy09
Add tests for printer package
9f5235f 
Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Remove TestWriteMultipleRows

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>
wzshiming
wzshiming approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joeyyy09, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@wzshiming
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit b08e17f into kubernetes-sigs:main May 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzshiming wzshiming wzshiming approved these changes

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@wzshiming wzshiming

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joeyyy09 @k8s-ci-robot @wzshiming