Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tests for the Pools package. #1089

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added Tests for the Pools package. #1089

wants to merge 1 commit into from

Conversation

joeyyy09
Copy link
Contributor

@joeyyy09 joeyyy09 commented May 18, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds additional test cases and edge cases for the pools package, enhancing the reliability of the pool implementation.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joeyyy09
Once this PR has been reviewed and has the lgtm label, please assign wzshiming for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @joeyyy09. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 18, 2024
@netlify Netlify
Copy link

netlify bot commented May 18, 2024 •
edited

✅ Deploy Preview for k8s-kwok ready!

Name Link
🔨 Latest commit 9b7d71d
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6656fd85804fa60008e5df97
😎 Deploy Preview https://deploy-preview-1089--k8s-kwok.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeyyy09 joeyyy09 changed the title Pools tests Added Tests for the pools package. May 18, 2024
@joeyyy09 joeyyy09 changed the title Added Tests for the pools package. Added Tests for the Pools package. May 18, 2024
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 20, 2024
wzshiming
wzshiming reviewed May 22, 2024
View reviewed changes
pkg/utils/pools/pools_test.go Outdated Show resolved Hide resolved
pkg/utils/pools/pools_test.go Outdated Show resolved Hide resolved
pkg/utils/pools/pools_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 22, 2024
@joeyyy09
Add tests for pools
9b7d71d 
Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Fix linting issues

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Add check for duplicate value

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzshiming wzshiming wzshiming left review comments

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joeyyy09 @k8s-ci-robot @wzshiming