Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test cases for Format, ProgressBar, Reader pkgs. #1088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added test cases for Format, ProgressBar, Reader pkgs. #1088

wants to merge 1 commit into from

Conversation

joeyyy09
Copy link
Contributor

@joeyyy09 joeyyy09 commented May 18, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds test cases for the formatInfo, NewTransport, and NewReader functions in the pkg/utils/progressbar package.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

@joeyyy09: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind test

What this PR does / why we need it:

This PR adds test cases for the formatInfo, NewTransport, and NewReader functions in the pkg/utils/progressbar package.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

No.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joeyyy09
Once this PR has been reviewed and has the lgtm label, please assign huang-wei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @joeyyy09. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 18, 2024
@netlify Netlify
Copy link

netlify bot commented May 18, 2024 •
edited

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 1425047
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6656f86332e1aa00081d31f2

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 20, 2024
wzshiming
wzshiming reviewed May 22, 2024
View reviewed changes
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests did not actually test any features.

pkg/utils/progressbar/format_test.go Outdated Show resolved Hide resolved
pkg/utils/progressbar/format_test.go Outdated Show resolved Hide resolved
pkg/utils/progressbar/format_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 22, 2024
@joeyyy09 joeyyy09 changed the title Added test cases for formatInfo, NewTransport, and NewReader functions. Added test cases for Format, ProgressBar, Reader pkgs. May 22, 2024
@joeyyy09
Copy link
Contributor Author

Hey @wzshiming I've added the test files for the format, progressbar, reader.go files. Can you please have a look at them?

@joeyyy09
Add tests for progressbar.go
1425047 
Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

improved file structure

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Add tests for format, progressbar,reader

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Add tests for progressbar

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Add tests for progressbar

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Add tests for reader

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Use httptest newserver

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Update linti

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>
@joeyyy09
Copy link
Contributor Author

@wzshiming I've made the required changes and also squashed all the commits. Can you take a look at them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzshiming wzshiming wzshiming left review comments

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joeyyy09 @k8s-ci-robot @wzshiming