Fix warnings in golangci linter #1085

joeyyy09 · 2024-05-17T09:55:50Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates the .golangci.yaml file to address the following warnings:

Deprecated configuration options linters.staticcheck.go and linters.stylecheck.go are replaced with global run.go.
Moved exclude files configuration from the deprecated run.skip-files to issues.exclude-files.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

NONE

k8s-ci-robot · 2024-05-17T09:55:57Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joeyyy09
Once this PR has been reviewed and has the lgtm label, please assign yibozhuang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2024-05-17T09:56:00Z

Hi @joeyyy09. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2024-05-17T09:56:08Z

✅ Deploy Preview for k8s-kwok canceled.

Name	Link
🔨 Latest commit	`005d03f`
🔍 Latest deploy log	https://app.netlify.com/sites/k8s-kwok/deploys/6656d63a324f9b00082c267c

wzshiming · 2024-05-17T10:07:23Z

/ok-to-test

wzshiming · 2024-05-17T10:06:41Z

.golangci.yaml

-  - staticcheck
-  - stylecheck


Why turn off the check, it works fine.

i didnt turn off the check, static check and style check are deprecated and it's covered under the global run.go in the later versions so they're performing the actions under the global run.go as per the docs i've see., PFA the image where the warnings and the logs are shown. I've made the changes according to the logs itself. Let me know if i've got to change this

wzshiming · 2024-05-17T10:11:35Z

.github/workflows/golangci-lint.yaml

      uses: golangci/golangci-lint-action@v3
      with:
        version: v1.55.2


All checks are version dependent, the current version of lint has no warnings in CI, you should upgrade this version and fix the warnings.

All checks are version dependent, the current version of lint has no warnings in CI, you should upgrade this version and fix the warnings.

Okay, will look into this

I've bumped up the version to 1.58 as per your suggestion in the new commit

wzshiming · 2024-05-21T03:43:54Z

.github/workflows/golangci-lint.yaml

@@ -17,4 +17,4 @@ jobs:
      uses: golangci/golangci-lint-action@v3
      with:
        version: v1.55.2


Suggested change

version: v1.55.2

version: v1.58.2

And also bump following

https://github.com/kubernetes-sigs/kwok/blob/main/hack/update-go-lint.sh
https://github.com/kubernetes-sigs/kwok/blob/main/hack/verify-go-lint.sh

.github/workflows/golangci-lint.yaml

joeyyy09 · 2024-05-21T12:10:30Z

@wzshiming I've fixed all the warnings and errors. Can you please have a look at them?

wzshiming · 2024-05-22T07:18:21Z

Still, pull-kwok-verify-main — Job failed.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kwok/1085/pull-kwok-verify-main/1792890641768779776

.golangci.yaml

wzshiming

Squash commits and rebase to main

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> Bump golangci version to the latest version Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> Bump golangci version to the latest version Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> Bump golangci version to the latest version Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> Change golangci-lint version to v1.55.2 Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

* Add Test Cases for slices package Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> * Fix linting issues Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> * Fix linting issues Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> --------- Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 6. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3...v6) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> Made faulty reader a field to be more generic Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Fix warnings in golangci linter Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> Update .golangci.yaml Co-authored-by: Shiming Zhang <wzshiming@hotmail.com> Fix issues Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

k8s-ci-robot · 2024-05-29T07:16:15Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2024-05-29T07:16:59Z

@joeyyy09: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kwok-build-main	`005d03f`	link	true	`/test pull-kwok-build-main`
pull-kwok-e2e-test-main	`005d03f`	link	true	`/test pull-kwok-e2e-test-main`
pull-kwok-unit-test-main	`005d03f`	link	true	`/test pull-kwok-unit-test-main`
pull-kwok-verify-main	`005d03f`	link	true	`/test pull-kwok-verify-main`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot requested review from Huang-Wei and yuanchen8911 May 17, 2024 09:55

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2024

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2024

wzshiming reviewed May 17, 2024

View reviewed changes

wzshiming reviewed May 21, 2024

View reviewed changes

wzshiming reviewed May 24, 2024

View reviewed changes

.golangci.yaml Outdated Show resolved Hide resolved

.golangci.yaml Outdated Show resolved Hide resolved

wzshiming reviewed May 29, 2024

View reviewed changes

joeyyy09 and others added 7 commits May 29, 2024 12:41

Update Prometheus Data Source Docs for Grafana

e7dafcd

[kwokctl] Support for all about nerdctl as runtime

28e4ce2

Fix node info not filling

9dd8b22

Remove auto bump k8s release on ci

5bcd359

Bump k8s releases

8a1a07a

Update testdata

e359174

network-charles and others added 5 commits May 29, 2024 12:41

Add hostIP url to prometheus.md

194ceb2

Update Test Cases for tail package

8e2f83f

Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> Made faulty reader a field to be more generic Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

Bump go to 1.22

005d03f

Fix warnings in golangci linter Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in> Update .golangci.yaml Co-authored-by: Shiming Zhang <wzshiming@hotmail.com> Fix issues Signed-off-by: Joeyyy09 <imt_2021063@iiitm.ac.in>

joeyyy09 force-pushed the update-lint branch from 2c2b6f0 to 005d03f Compare May 29, 2024 07:16

k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label May 29, 2024

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2024

joeyyy09 closed this May 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix warnings in golangci linter #1085

Fix warnings in golangci linter #1085

joeyyy09 commented May 17, 2024 •

edited

k8s-ci-robot commented May 17, 2024

k8s-ci-robot commented May 17, 2024

netlify bot commented May 17, 2024 •

edited

wzshiming commented May 17, 2024

wzshiming May 17, 2024

joeyyy09 May 17, 2024 •

edited

wzshiming May 17, 2024

joeyyy09 May 17, 2024

joeyyy09 May 17, 2024

wzshiming May 21, 2024

joeyyy09 commented May 21, 2024

wzshiming commented May 22, 2024

wzshiming left a comment

k8s-ci-robot commented May 29, 2024

k8s-ci-robot commented May 29, 2024

Fix warnings in golangci linter #1085

Fix warnings in golangci linter #1085

Conversation

joeyyy09 commented May 17, 2024 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

k8s-ci-robot commented May 17, 2024

k8s-ci-robot commented May 17, 2024

netlify bot commented May 17, 2024 • edited

✅ Deploy Preview for k8s-kwok canceled.

wzshiming commented May 17, 2024

wzshiming May 17, 2024

Choose a reason for hiding this comment

joeyyy09 May 17, 2024 • edited

Choose a reason for hiding this comment

wzshiming May 17, 2024

Choose a reason for hiding this comment

joeyyy09 May 17, 2024

Choose a reason for hiding this comment

joeyyy09 May 17, 2024

Choose a reason for hiding this comment

wzshiming May 21, 2024

Choose a reason for hiding this comment

joeyyy09 commented May 21, 2024

wzshiming commented May 22, 2024

wzshiming left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 29, 2024

k8s-ci-robot commented May 29, 2024

joeyyy09 commented May 17, 2024 •

edited

netlify bot commented May 17, 2024 •

edited

joeyyy09 May 17, 2024 •

edited