Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update peer_with_router.yml #11186

Closed
wants to merge 24 commits into from
Closed

Update peer_with_router.yml #11186

wants to merge 24 commits into from

Conversation

ehsan310
Copy link
Contributor

Check if peers is defined when peering with routers

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

In case you have your bgp filters and bgp peers configured on gitops like Argocd then i need to make sure nodetonode mesh is disabled and do peering via Argo.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This change is required to make a way for peering with ToR out of Kubespray

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ehsan310. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2024
@yankay
Copy link
Member

yankay commented May 14, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2024
@ehsan310
Update peer_with_router.yml
cd15c7b 
Check if peers is defined when peering with routers
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ehsan310
Once this PR has been reviewed and has the lgtm label, please assign oomichi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tico88612 and others added 14 commits May 31, 2024 21:43
@tico88612 @ehsan310
Docs: update ubuntu support version & docker version (kubernetes-sigs…
bad08fd 
…#11231)

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@dependabot @ehsan310
Bump ansible from 9.5.1 to 9.6.0
0c00a0f 
Bumps [ansible](https://github.com/ansible-community/ansible-build-data) from 9.5.1 to 9.6.0.
- [Changelog](https://github.com/ansible-community/ansible-build-data/blob/main/docs/release-process.md)
- [Commits](ansible-community/ansible-build-data@9.5.1...9.6.0)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@VannTen @ehsan310
Use alternate self-sufficient shellcheck precommit
8bf47f7 
This pre-commit does not require prerequisite on the host, making it
easier to run in CI workflows.
@VannTen @ehsan310
Switch to upstream ansible-lint pre-commit hook
80fbe82 
This way, the hook is self contained and does not depend on a previous
virtualenv installation.
@VannTen @ehsan310
pre-commit: fix hooks dependencies
fc34cee 
- ansible-syntax-check
- tox-inventory-builder
- jinja-syntax-check
@VannTen @ehsan310
Fix ci-matrix pre-commit hook
9ffffdc 
- Remove dependency of pydblite which fails to setup on recent pythons
- Discard shell script and put everything into pre-commit
@VannTen @ehsan310
pre-commit: apply autofixes hooks and fix the rest manually
a8e1444 
- markdownlint (manual fix)
- end-of-file-fixer
- requirements-txt-fixer
- trailing-whitespace
@VannTen @ehsan310
Convert check_typo to pre-commit + use maintained version
e7d6fb7 
client9/misspell is unmaintained, and has been forked by the golangci
team, see client9/misspell#197 (comment).

They haven't yet added a pre-commit config, so use my fork with the
pre-commit hook config until the pull request is merged.
@VannTen @ehsan310
collection-build-install convert to pre-commit
6299e93
@VannTen @ehsan310
Run pre-commit hooks in dynamic pipeline
0ee5351 
Use gitlab dynamic child pipelines feature to have one source of truth
for the pre-commit jobs, the pre-commit config file.

Use one cache per pre-commit. This should reduce the "fetching cache"
time steps in gitlab-ci, since each job will have a separate cache with
only its hook installed.
@VannTen @ehsan310
Remove gitlab-ci job done in pre-commit
89331a5
@VannTen @ehsan310
pre-commit: adjust mardownlint default, md fixes
45f622f 
Use a style file as recommended by upstream. This makes for only one
source of truth.
Conserve previous upstream default for MD007 (upstream default changed
here markdownlint/markdownlint#373)
@VannTen @ehsan310
Update pre-commit hooks
8108340
@ant31 @ehsan310
owners: move ant31 from emeritus to approvers (kubernetes-sigs#11247)
a9ab584
VannTen and others added 9 commits May 31, 2024 21:43
@VannTen @ehsan310
Allow empty kube_node group (kubernetes-sigs#11248)
b14e73a 
While uncommon, provisioning only a control plane is a valid use case,
so don't block it.
@VannTen @ehsan310
collection support: use manifest instead of excludes
1d30609 
The default for galaxy. `manifest` works well enough for our case, and
this avoids maintaining a blacklist.
@hedayat @ehsan310
Add 'system-packages' tag to control installing packages from OS repo…
043b855 
…sitories (kubernetes-sigs#10872)
@spnngl @ehsan310
fix(bootstrap-os): do not install pkgs requirements on flatcar (kuber…
789b5f2 
…netes-sigs#11224)

Fix regression added in 663fcd1 for
flatcar nodes.

See: kubernetes-sigs@663fcd1
@dependabot @ehsan310
Bump pytest-testinfra from 10.1.0 to 10.1.1
137bf97 
Bumps [pytest-testinfra](https://github.com/pytest-dev/pytest-testinfra) from 10.1.0 to 10.1.1.
- [Release notes](https://github.com/pytest-dev/pytest-testinfra/releases)
- [Changelog](https://github.com/pytest-dev/pytest-testinfra/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-testinfra@10.1.0...10.1.1)

---
updated-dependencies:
- dependency-name: pytest-testinfra
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@jmaccabee13 @ehsan310
fix Hetzner group names (kubernetes-sigs#11232)
8ee43eb 
The inventory file generated by Terraform produces the following warnings:
```
[WARNING]:  * Failed to parse <PATH>/kubespray/contrib/terraform/hetzner/inventory.ini with ini plugin:
<PATH>/kubespray/contrib/terraform/hetzner/inventory.ini:21: Section [k8s_cluster:children] includes undefined group: kube-master
...
[WARNING]: Could not match supplied host pattern, ignoring: kube-master

PLAY [Add kube-master nodes to kube_control_plane] ********************************************************************************************************
skipping: no hosts matched
[WARNING]: Could not match supplied host pattern, ignoring: kube-node

PLAY [Add kube-node nodes to kube_node] *******************************************************************************************************************
skipping: no hosts matched
```
@ant31 @ehsan310
CI require a 'lgtm' or 'ok-to-test' labels to pass (kubernetes-sigs#1…
d9e15cd 
…1251)

- Require a 'lgtm' or 'ok-to-test' label for running CI after the
  moderator stage

Signed-off-by: ant31 <2t.antoine@gmail.com>
@yankay @ehsan310
fix auto bump PR is blocked by label (kubernetes-sigs#11256)
5f2d0ae
@itayporezky @ehsan310
Removed unnecessary python modules (kubernetes-sigs#11199)
0f07ae0
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/contains-merge-commits size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2024
@ehsan310 ehsan310 closed this May 31, 2024
@ehsan310
Copy link
Contributor Author

Closing this to create a newone via branch

@ehsan310 ehsan310 mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian Awaiting requested review from mzaian

@yankay yankay Awaiting requested review from yankay

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@ehsan310 @k8s-ci-robot @yankay @tico88612 @VannTen @ant31 @hedayat @spnngl @jmaccabee13 @itayporezky