-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-add api-approved.kubernetes.io annotation #4488
fix: re-add api-approved.kubernetes.io annotation #4488
Conversation
Hi @morremeyer. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
To whoever reviews this: Is make crd run by any CI or should I run it locally and commit the changes, too? |
@morremeyer Yes, please commit it. Can you also fix |
@mloiseleur Done, thank you. I'm not sure if Running export GOBIN=/Users/mmeyer/go/bin
make crd works now. |
/ok-to-test |
/lgtm cancel |
|
99b0c40
to
b3dd3b1
Compare
b3dd3b1
to
41e4266
Compare
41e4266
to
c0a183b
Compare
@mloiseleur Got it, thanks. Indeed my GOPATH was not set correctly for whatever reason. I took the liberty of fix-upping and force-pushing your suggestions to fix the CLA check. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can we have a release of this? |
Description
This re-adds the
api-approved.kubernetes.io
annotation that was removed with 4e6dd80.Fixes #4487.
Fixes #4483.
I verified this locally by running
since
make controller-gen
did not work on my system, likely because I didn't use it correctly.And then
to generate the CRD
Checklist