-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: upgrade mkdocs and fix broken links #4378
docs: upgrade mkdocs and fix broken links #4378
Conversation
4e30593
to
3c73efd
Compare
@szuecs Thanks for your review. For your other comments, the problem is the way it works currently. That makes relative links broken. So I see two solutions:
Wdyt of those options ? any other idea ? |
@mloiseleur the second option maybe? I'm not sure aware of the consequences, but duplicating the README is not super great. If we can have an alternative document that doesn't require us to update things in two places every time, then I'm also fine with 1. |
@Raffo @szuecs mkdocs does not support to use README.md at the root level, see this upstream issue. Nevertheless, there is a plugin that workaround this. |
Thanks! Ping me for a review anytime. |
from my side lgtm |
8b9af8f
to
f7b623c
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
It upgrades the whole stack.
Checklist
Additional notes
mkdocs serve
is clean, except a Warning on /version.json:WARNING - [14:24:16] "GET /versions.json HTTP/1.1" code 404
Hopefully, it will be served by
mike
, but I haven't found how to launch successfully mike on a local branch.