Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: upgrade mkdocs and fix broken links #4378

Merged
merged 7 commits into from
Jun 11, 2024

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Apr 10, 2024

Description

It upgrades the whole stack.

Checklist

  • Unit tests updated
  • End user documentation updated

Additional notes

mkdocs serve is clean, except a Warning on /version.json:

WARNING -  [14:24:16] "GET /versions.json HTTP/1.1" code 404

Hopefully, it will be served by mike, but I haven't found how to launch successfully mike on a local branch.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2024
@mloiseleur mloiseleur changed the title docs: upgrade mkdocs and fix warnings docs: upgrade mkdocs and fix broken links Apr 10, 2024
.github/workflows/docs.yml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2024
@mloiseleur
Copy link
Contributor Author

@szuecs Thanks for your review.

For your other comments, the problem is the way it works currently.
The README.md is used as front page doc on https://github.com/kubernetes-sigs/external-dns
It's also copied in docs/ before generating the mkdocs website.

That makes relative links broken. So I see two solutions:

  1. Split this README into two : one in / and the other in docs/ of this repo
  2. Try to generate the mkdocs without moving the README.md in docs/

Wdyt of those options ? any other idea ?

@Raffo
Copy link
Contributor

Raffo commented May 11, 2024

@mloiseleur the second option maybe? I'm not sure aware of the consequences, but duplicating the README is not super great. If we can have an alternative document that doesn't require us to update things in two places every time, then I'm also fine with 1.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 3, 2024
@mloiseleur
Copy link
Contributor Author

@Raffo @szuecs mkdocs does not support to use README.md at the root level, see this upstream issue. Nevertheless, there is a plugin that workaround this.
The plugin seems to work, so I give it a go.

@Raffo
Copy link
Contributor

Raffo commented Jun 3, 2024

Thanks! Ping me for a review anytime.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2024
@szuecs
Copy link
Contributor

szuecs commented Jun 6, 2024

from my side lgtm

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2024
@mloiseleur
Copy link
Contributor Author

@Raffo @szuecs PR has been rebased. I also added a link to doc website.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2024
@Raffo
Copy link
Contributor

Raffo commented Jun 11, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit b84fc93 into kubernetes-sigs:master Jun 11, 2024
13 checks passed
@mloiseleur mloiseleur deleted the docs/upgrade-mkdocs branch June 11, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants