-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry): support all "managed" record types #4342
base: master
Are you sure you want to change the base?
feat(registry): support all "managed" record types #4342
Conversation
Welcome @haslersn! |
Hi @haslersn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Previously, the registry only supported certain hard-coded record types (A, AAAA, CNAME, NS). With this commit, we instead take the list of types given via --managed-record-types. That means the default now is A, AAAA, CNAME (i.e., NS is no longer included), but I don't think this is a breaking change, because any changes to records that aren't "managed" are filtered out at a later point anyway. Now other record types (such as TXT) can also be handled by the TXT registry. I have tested this by creating a DNSEndpoint with TXT targets and then deleting the DNSEndpoint again. The record and heritage record are correctly created and deleted. Signed-off-by: Sebastian Hasler <sebastian@hasler.dev>
13c98b7
to
3e1eb24
Compare
Thanks for this PR @haslersn ! |
/ok-to-test |
@haslersn: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Previously, the registry only supported certain hard-coded record types (A, AAAA, CNAME, NS). With this commit, we instead take the list of types given via --managed-record-types. That means the default now is A, AAAA, CNAME (i.e., NS is no longer included), but I don't think this is a breaking change, because any changes to records that aren't "managed" are filtered out at a later point anyway.
Now other record types (such as TXT) can also be handled by the TXT registry.
I have tested this by creating a DNSEndpoint with TXT targets and then deleting the DNSEndpoint again. The record and heritage record are correctly created and deleted.
Description
Fixes #ISSUE
Checklist