feat(rfc2136): add PTR optional support

[angeloxx]

Description

The PR extends the existing RFC2136 provider within external-dns, incorporating logic to handle PTR record creation and deletion alongside the management of other DNS record types. The functionality is disabled by default and can be activated with --rfc2136-create-ptr (similar to infoblox flag) in order to keep current behaviour during an upgrade.

Checklist

• End user documentation updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: angeloxx / name: angeloxx (a0040a4, 0efdfb3, b083e34, 5c01e95, 2f7f639, 940899b, bab7a84, cd2088d, 1d93309)

[k8s-ci-robot]

Welcome @angeloxx!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @angeloxx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[angeloxx]

/hold

[angeloxx]

/unhold

[k8s-ci-robot]

@angeloxx: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[angeloxx]

PR updated with changes from current master.

[angeloxx]

/lgtm

[k8s-ci-robot]

@angeloxx: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mloiseleur]

/ok-to-test
Thanks. The PR looks good, comes with test and is documented.

[mloiseleur]

/lgtm

[mloiseleur]

/retitle feat(rfc2136): add PTR optional support

[szuecs]

I don't see a test that checks that PTR is enabled and we got a PTR record.

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mloiseleur. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[angeloxx]

I don't see a test that checks that PTR is enabled and we got a PTR record.

You're right, I just added a test that verifies the (correct) creation of a reverse.