fix: TXT record when killed at the wrong time
#4117
Conversation
**why?** `TXT` entries are very special because external-dns use it to "lock" the owner currently, a DNS will be like that: ``` time="2023-12-16T16:50:40Z" level=info msg="Changing record." action=CREATE record=oops-test... ttl=1 type=CNAME zone=ff... time="2023-12-16T16:50:41Z" level=info msg="Changing record." action=CREATE record=edns-cf-oops-test... ttl=1 type=TXT zone=ff.. time="2023-12-16T16:50:41Z" level=info msg="Changing record." action=CREATE record=edns-cf-cname-oops-test... ttl=1 type=TXT zone=ff... ``` most of the time it's ok but in some cases, sh*t happen and external-dns pod can be killed at the wrong time and it can be annoying because if only the `CNAME` record is created, then external-dns can't update or remove it **how** In fact we have to managed two cases: creation & deletion If we create TXT records in a first step during creation and remove TXT in a last step for deletion we can avoid it safely Maybe this could be made also in other providers
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @PascalBourdier. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
Hello @PascalBourdier, Thanks for this interesting PR ! |
I don't know how to add this test case |
|
@PascalBourdier I think the bigger problem is, that you fix it only in one provider and maybe we should fix it in all at once. |
In fact, it is a first version and you're right we should do it for all providers |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
k8s-ci-robot
changed the title
TXT recordsTXT record when killed at the wrong time
why?
TXTentries are very special because external-dns use it to "lock" the ownercurrently, a DNS will be like that:
most of the time it's ok but in some cases, sh*t happen and external-dns pod can be killed at the wrong time
and it can be annoying because if only the
CNAMErecord is created, then external-dns can't update or remove ithow
In fact we have to managed two cases: creation & deletion
If we create TXT records in a first step during creation and remove TXT in a last step for deletion we can avoid it safely
Maybe this could be made also in other providers
Description
Fixes #ISSUE
Checklist