Change of LocalVariableCouldBeFinal #147
Conversation
There was a problem hiding this comment.
Generally I agree and prefer constants over variables, but as the title says these could be final. However, it doesn mean they should or must.
PMD is a tool that does static analysis based on hard-coded rules - i.e. without actual understanding over the code being inspected - and in the end the decision is yours.
In this PR most changes are surrounded by short and concise code, leaving very little room for errors regarding variable re-assignment. Hence, the only place where I find using final truly feasible is the GenericTypeResolver, because the code there is slightly more complex. But even there, the flow is quite straight-forward and the intermediate variables are mainly used to store next child while drilling down the object hierarchy.
I have a feeling this is related to some sort of assigment work, so I'd suggest to study PMD rule(s) and then look at the code and think carefully if the suggested changes make difference in code quality or not.
#146