Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYCL: Print submission command queue property #7004

Merged

Conversation

masterleinad
Copy link
Contributor

Related to #6912 and #7003. Prior to intel/llvm#12279 and oneapi-src/unified-runtime#1218, the oneAPI implementation didn't support immediate command lists.
There are different ways to make sure to use the standard command queue:

This pull request just detects if given queues have been constructed with either property. This should give enough information to diagnose potential problems with Graphs. The intended way to fix any related issues is to set SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS.

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(once you fixed the format)

Co-authored-by: Damien L-G <dalg24+github@gmail.com>
@masterleinad masterleinad force-pushed the sycl_print_submission_command_queue branch from 9195ddb to 027dfb4 Compare May 9, 2024 20:37
@masterleinad
Copy link
Contributor Author

Only CUDA-11.6-NVCC-DEBUG failed with connectivity issues on fetnat03.

@masterleinad masterleinad requested a review from nliber May 10, 2024 12:02
@dalg24 dalg24 merged commit 1d9d0df into kokkos:develop May 10, 2024
28 of 29 checks passed
@ndellingwood
Copy link
Contributor

@masterleinad does this merit a 4.4 changelog entry?

@masterleinad
Copy link
Contributor Author

@masterleinad does this merit a 4.4 changelog entry?

Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants