Suppress deprecated warnings via pragma push/pop in the tests #6999
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to suppress diagnostics when appropriate
dalg24
added
Failure - Nightly
dalg24
commented
May 8, 2024
and provide a fallback empty definition for the macros
dalg24
changed the title
Rombur
reviewed
May 13, 2024
dalg24
added a commit
to dalg24/kokkos
that referenced
this pull request
May 21, 2024
Fixup for kokkos#6999 Deprecation warnings are still showing in the OpenACC CI build ``` "/var/jenkins/workspace/Kokkos_PR-7017/core/unit_test/TestArrayOps.hpp", line 136: warning: class "Kokkos::Array<int, 18446744073709551615UL, Kokkos::Impl::KokkosArrayContiguous>" was declared deprecated [deprecated_entity] using A = ^ "/var/jenkins/workspace/Kokkos_PR-7017/core/src/Kokkos_Array.hpp", line 217: note: because of a "deprecated" attribute struct KOKKOS_DEPRECATED ^ Remark: individual warnings can be suppressed with "--diag_suppress <warning-name>" "/var/jenkins/workspace/Kokkos_PR-7017/core/unit_test/TestArrayOps.hpp", line 197: warning: class "Kokkos::Array<int, 18446744073709551615UL, Kokkos::Impl::KokkosArrayContiguous>" was declared deprecated [deprecated_entity] using A = ^ "/var/jenkins/workspace/Kokkos_PR-7017/core/src/Kokkos_Array.hpp", line 217: note: because of a "deprecated" attribute struct KOKKOS_DEPRECATED ^ "/var/jenkins/workspace/Kokkos_PR-7017/core/unit_test/TestArrayOps.hpp", line 274: warning: class "Kokkos::Array<int, 18446744073709551615UL, Kokkos::Impl::KokkosArrayStrided>" was declared deprecated [deprecated_entity] using A = Kokkos::Array<int, KOKKOS_INVALID_INDEX, Kokkos::Array<>::strided>; ^ "/var/jenkins/workspace/Kokkos_PR-7017/core/src/Kokkos_Array.hpp", line 286: note: because of a "deprecated" attribute struct KOKKOS_DEPRECATED ^ "/var/jenkins/workspace/Kokkos_PR-7017/core/unit_test/TestArrayOps.hpp", line 338: warning: class "Kokkos::Array<int, 18446744073709551615UL, Kokkos::Impl::KokkosArrayStrided>" was declared deprecated [deprecated_entity] using A = Kokkos::Array<int, KOKKOS_INVALID_INDEX, Kokkos::Array<>::strided>; ^ "/var/jenkins/workspace/Kokkos_PR-7017/core/src/Kokkos_Array.hpp", line 286: note: because of a "deprecated" attribute struct KOKKOS_DEPRECATED ^ ``` The generic EDG warning disable did not work so we handle NVC++ separately and push a diag_suppress pragma. In case anyone wants to try something else https://godbolt.org/z/nxWbPMT95
dalg24
added a commit
to dalg24/kokkos
that referenced
this pull request
May 21, 2024
Fixup for kokkos#6999 Deprecation warnings are still showing in the OpenACC CI build ``` "/var/jenkins/workspace/Kokkos_PR-7017/core/unit_test/TestArrayOps.hpp", line 136: warning: class "Kokkos::Array<int, 18446744073709551615UL, Kokkos::Impl::KokkosArrayContiguous>" was declared deprecated [deprecated_entity] using A = ^ "/var/jenkins/workspace/Kokkos_PR-7017/core/src/Kokkos_Array.hpp", line 217: note: because of a "deprecated" attribute struct KOKKOS_DEPRECATED ^ Remark: individual warnings can be suppressed with "--diag_suppress <warning-name>" "/var/jenkins/workspace/Kokkos_PR-7017/core/unit_test/TestArrayOps.hpp", line 197: warning: class "Kokkos::Array<int, 18446744073709551615UL, Kokkos::Impl::KokkosArrayContiguous>" was declared deprecated [deprecated_entity] using A = ^ "/var/jenkins/workspace/Kokkos_PR-7017/core/src/Kokkos_Array.hpp", line 217: note: because of a "deprecated" attribute struct KOKKOS_DEPRECATED ^ "/var/jenkins/workspace/Kokkos_PR-7017/core/unit_test/TestArrayOps.hpp", line 274: warning: class "Kokkos::Array<int, 18446744073709551615UL, Kokkos::Impl::KokkosArrayStrided>" was declared deprecated [deprecated_entity] using A = Kokkos::Array<int, KOKKOS_INVALID_INDEX, Kokkos::Array<>::strided>; ^ "/var/jenkins/workspace/Kokkos_PR-7017/core/src/Kokkos_Array.hpp", line 286: note: because of a "deprecated" attribute struct KOKKOS_DEPRECATED ^ "/var/jenkins/workspace/Kokkos_PR-7017/core/unit_test/TestArrayOps.hpp", line 338: warning: class "Kokkos::Array<int, 18446744073709551615UL, Kokkos::Impl::KokkosArrayStrided>" was declared deprecated [deprecated_entity] using A = Kokkos::Array<int, KOKKOS_INVALID_INDEX, Kokkos::Array<>::strided>; ^ "/var/jenkins/workspace/Kokkos_PR-7017/core/src/Kokkos_Array.hpp", line 286: note: because of a "deprecated" attribute struct KOKKOS_DEPRECATED ^ ``` The generic EDG warning disable did not work so we handle NVC++ separately and use diagnostic pragmas. In case anyone wants to try something else https://godbolt.org/z/nxWbPMT95
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
KOKKOS_IMPL_DISABLE_DEPRECATED_WARNINGS_{PUSH,POP}macros to suppress diagnostics when appropriate and fix all the warnings I could see in our tests.Just in case we need to rework the suppressions macros https://godbolt.org/z/Pjd7hYba9