Allow functors as reducers for nested team parallel reduce #6921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldh4
force-pushed
the
functors_as_reducers_nested_policies
branch
from
56716f9
to
cd00bd8
Compare
…torRange in HostThreadTeam
…torRange for Cuda
…torRange for SYCL
ldh4
force-pushed
the
functors_as_reducers_nested_policies
branch
from
05b6edf
to
684bb69
Compare
Only |
Comment on lines
+533
to
+535
| constexpr bool is_reducer_closure = | ||
| functor_analysis_type::has_join_member_function && | ||
| functor_analysis_type::has_init_member_function; |
There was a problem hiding this comment.
Suggested change
| constexpr bool is_reducer_closure = | |
| functor_analysis_type::has_join_member_function && | |
| functor_analysis_type::has_init_member_function; | |
| constexpr bool is_reducer_closure = | |
| functor_analysis_type::has_join_member_function; |
Comment on lines
+537
to
+539
| using ReducerSelector = | ||
| typename Kokkos::Impl::if_c<is_reducer_closure, Closure, | ||
| Sum<ValueType>>::type; |
There was a problem hiding this comment.
Why are you not using functor_analysis_type::Reducer? Because that type is not compatible with team_reduce?
Either way, ReducerSelector is only used below in the !is_reducer_closure branch. So there is no need for this alias.
Comment on lines
+617
to
+619
| using ReducerSelector = | ||
| typename Kokkos::Impl::if_c<is_reducer_closure, Closure, | ||
| Sum<ValueType>>::type; |
Comment on lines
+303
to
+305
| if constexpr (is_reducer_v<ReducerType>) { | ||
| reducer.reference() = tmp2; | ||
| })) |
There was a problem hiding this comment.
Why aren't we using final here if defined?
Comment on lines
+737
to
+739
| using ReducerSelector = | ||
| typename Kokkos::Impl::if_c<is_reducer_closure, Closure, | ||
| Sum<ValueType>>::type; |
Comment on lines
+1797
to
+1798
| KOKKOS_INLINE_FUNCTION | ||
| void final(value_type &) const {} |
There was a problem hiding this comment.
We should test with a non-trivial final as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6317.
This PR allows functors to be used as reducers in nested parallel reduction, specifically for
parallel_reducethat takes inTeamThreadRange,ThreadVectorRangeorTeamVectorRange.This capability is already available for reductions with
Range/MDRange/Teampolicies as noted in #6774.To stay consistent with the existing 'functors as reducers' behavior , changes in this PR expects:
ReducerArgumentis not a reducer typeinit()andjoin()definedReducerConcept(i.e. havingtypedef reducer = [ReducerStruct]is not required)