Only copy data in UnorderedMap deep_copy #6812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previous behavior was closer to create_mirror_view_and_copy - Now, no changes to meta data, only assert capacity matches and deep copy view data - add a create_mirror() function for UnorderedMaps
tcclevenger
commented
Feb 13, 2024
|
Fails on SYCL and HIP builds appear unrelated. I manually tested container unit tests on MI100 (caraway) and got passes for Serial and HIP tests. |
masterleinad
approved these changes
Feb 20, 2024
crtrott
approved these changes
Apr 28, 2024
|
Retest this please |
1 similar comment
|
Retest this please |
|
I think the only fail is a CI issue, not with this PR. |
|
Only |
|
@dalg24 @tcclevenger does this merit an entry for the 4.4 changelog? Since it is a change of behavior, including deprecation, it seems notable to add? |
|
Deferring to Christian and Conrad. |
|
Yeah, this probably deserves an entry. I'll add one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
deep_copy(UnorderedMap,UnorderedMap)acted much more similar tocreate_mirror_view_and_copy()which allocated the dst view and then deep_copy the data. Now deep_copy requires the capacity of the src and dst UnorderedMaps are identical and deep copies all data from src to dst.Also changed
UnorderedMap::create_copy_view()intoallocate_view()anddeep_copy_view()create_mirror(UnorderedMap)specialization