Apply CI compiler warning flags in CMake #1809
Conversation
| @@ -824,6 +824,6 @@ cd $STORE_KOKKOSKERNELS_BUILD_PATH | |||
|
|
|||
| # Configure kokkos-kernels | |||
| echo "" | |||
| echo cmake $COMPILER_CMD -DKokkos_DIR="${KOKKOS_FIND_PATH}" -DCMAKE_CXX_FLAGS=\"${KOKKOS_CXXFLAGS}\" -DCMAKE_INSTALL_PREFIX="${PREFIX}" -DKokkosKernels_ENABLE_TESTS_AND_PERFSUITE=${KOKKOSKERNELS_DO_PERFSUITE} -DKokkosKernels_ENABLE_TESTS=${KOKKOSKERNELS_DO_TESTS} -DKokkosKernels_ENABLE_PERFTESTS=${KOKKOSKERNELS_DO_PERFTESTS} -DKokkosKernels_ENABLE_EXAMPLES:BOOL=${KOKKOSKERNELS_DO_EXAMPLES} -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=${CMAKE_EXPORT_COMPILE_COMMANDS} ${KOKKOSKERNELS_SCALARS_CMD} ${KOKKOSKERNELS_ORDINALS_CMD} ${KOKKOSKERNELS_OFFSETS_CMD} ${KOKKOSKERNELS_LAYOUTS_CMD} ${KOKKOSKERNELS_TPLS_CMD} ${KOKKOSKERNELS_USER_TPL_PATH_CMD} ${KOKKOSKERNELS_USER_TPL_LIBNAME_CMD} -DCMAKE_EXE_LINKER_FLAGS=\"${KOKKOSKERNELS_EXTRA_LINKER_FLAGS_PARSED}\" ${KOKKOSKERNELS_BUILDTYPE_CMD} -DBUILD_SHARED_LIBS=${BUILD_SHARED_LIBRARIES} ${KOKKOSKERNELS_COMPONENTS_CMD} ${KOKKOSKERNELS_SPACES_CMD} ${KERNELS_DEFAULT_ETI_OPTION} ${KERNELS_DEFAULT_TEST_ETI_ONLY_OPTION} -DKokkosKernels_ENABLE_DOCS=${KOKKOSKERNELS_DO_DOCS} ${KOKKOSKERNELS_PATH} | |||
There was a problem hiding this comment.
This is hard to read - it just adds -DKokkosKernels_ENABLE_COMPILER_WARNINGS=ON to each line
|
Thoughts on this general approach @e10harvey @lucbv? |
| @@ -819,40 +805,38 @@ elif [ "$MACHINE" = "kokkos-dev-2" ]; then | |||
| BUILD_LIST_CUDA_NVCC="Cuda_Serial,Cuda_Threads" | |||
| BUILD_LIST_CLANG="Serial,Threads,OpenMP" | |||
|
|
|||
| CLANG8_CUDA_WARNING_FLAGS="-Wall,-Wshadow,-pedantic,-Werror,-Wsign-compare,-Wtype-limits,-Wuninitialized,-Wno-pass-failed" | |||
There was a problem hiding this comment.
I don't think we support this anymore, so I didn't try to detect this scenario
There was a problem hiding this comment.
@cwpearson: Before merging, please add a documentation block to the top of cm_test_all_sandia noting to maintainers where compiler flags get set now. Please also share a diff CMakeCache_before_these_changes.txt CMakeCache_after_these_changes.txt for all configurations that we care about.
This approach looks reasonable to me. FWIW, this is a similar divergence that was used in trilinos (branching in both shell and cmake scripts for different systems and compilers) that led to significant complexity and maintainability challenges. These configuration use-cases are exactly what |
|
Converting this to an issue to possibly revisit later. |
This makes the warning flags we use in CI directly accessible in development with
-DKokkosKernels_ENABLE_COMPILER_WARNINGS=ON