Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Kokkos::Impl::assume_aligned for broader compiler support #1611

Closed
wants to merge 2 commits into from

Conversation

cwpearson
Copy link
Contributor

@cwpearson cwpearson commented Nov 30, 2022

This is a work in progress

  • gcc and clang have __builtin_assume_aligned
  • nvcc added assume_aligned in 11.2
  • msvc has __assume() which can be used in a similar way
  • intel has __assume_aligned
  • HIP?
  • What are the right macros to use to detect the compiler and host code vs device code?

If MSVC can't see __assume through a function return a pure macro-based approach may be more appropriate.

@cwpearson cwpearson changed the title Add Kokkos::Impl::assume_aligned for broader compiler support [WIP] Add Kokkos::Impl::assume_aligned for broader compiler support Nov 30, 2022
@cwpearson cwpearson marked this pull request as draft November 30, 2022 19:07
@cwpearson
Copy link
Contributor Author

Dropping this, not much progress was made and if we have a good use for it we can redo it.

@cwpearson cwpearson closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant