Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require authentication at the project level instead of the account level #904

Merged
merged 18 commits into from
Jan 11, 2024

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Oct 30, 2023

Description

Required authentication can be activated per project.

Additional info

Collect server setting must use Kobocat URL without username (e.g.: https://kc.kobotoolbox.org) with projects with authenticated required

Screenshot_20231107-104525

and it must use Kobocat URL with username and no credentials for those which allow anonymous users to submit data

Screenshot_20231107-104644

Briefcase Aggregate Server setting must use Kobocat URL without username
Screenshot 2023-11-07 at 10 35 33

Notes

Redis hset values changes have been added in the logger 0034 migration instead of KPI because it was easier to use logic at the database level (e.g. : XForm.objects.filter(user_id__in=UserProfile.objects.values_list('user_id')). KPI is not able to mix JOINs on separate databases.

@noliveleger noliveleger requested a review from jnm November 7, 2023 15:26
@noliveleger noliveleger changed the title WIP - Require auth at project level Require authentication at the project level instead of the account level Nov 7, 2023
@noliveleger noliveleger marked this pull request as ready for review November 7, 2023 15:51
Copy link

Copy link

onadata/apps/api/tests/viewsets/test_xform_list_api.py Outdated Show resolved Hide resolved
onadata/apps/api/viewsets/briefcase_api.py Outdated Show resolved Hide resolved
onadata/apps/api/viewsets/briefcase_api.py Outdated Show resolved Hide resolved
onadata/apps/api/viewsets/briefcase_api.py Outdated Show resolved Hide resolved
onadata/settings/base.py Outdated Show resolved Hide resolved
onadata/libs/utils/logger_tools.py Outdated Show resolved Hide resolved
onadata/libs/utils/briefcase_client.py Outdated Show resolved Hide resolved
onadata/apps/main/tests/test_base.py Outdated Show resolved Hide resolved
onadata/apps/api/viewsets/xform_list_api.py Outdated Show resolved Hide resolved
@jnm jnm changed the base branch from beta to release/2.023.52 December 30, 2023 03:35
@noliveleger noliveleger requested a review from jnm January 11, 2024 20:17
@jnm jnm merged commit c44af5a into release/2.023.52 Jan 11, 2024
1 check was pending
@jnm jnm deleted the require-auth-at-project-level branch January 11, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants