Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upate npm packages and fix enable binding #2566

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

manfredwippel
Copy link

No description provided.

updated node Modules due to vulnerabilities
Enable and disable might not work in Firefox and Chrome
element.disabled is also not supported in typescript definitions
@webketje
Copy link

webketje commented Sep 4, 2021

In what prehistoric, by Knockout supported browser is this assumption true?

//element.disabled may not work in every Browser

+1 for the devDependencies upgrade though

@manfredwippel
Copy link
Author

manfredwippel commented Sep 6, 2021

In what prehistoric, by Knockout supported browser is this assumption true?

//element.disabled may not work in every Browser

+1 for the devDependencies upgrade though

We had problems in some Firefox versions and changed it - years ago ;).

same problem here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants