-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documents parseHtmlFragment and setHtml #2129
base: master
Are you sure you want to change the base?
Documents parseHtmlFragment and setHtml #2129
Conversation
Prefer <template> tags over jQuery for setHtml.
@brianmhunt Looks like Travis Build didn't pass. I feel this is because of the warning. Some insights and help would be required. |
@manrajgrover tko.utils (where this was merged) passes: https://circleci.com/gh/knockout/tko-policy There are a long list of build & testing issues with knockout. See e.g. #1360 . |
The build failed with "The following files have trailing spaces that need to be cleaned up". Why does this fail the build? It's to prevent files with trailing spaces from being checked in so that later on, editors that automatically remove trailing spaces don't cause superfluous changes. |
@brianmhunt I'll have a look at the PR. So, contributions should now be make to @mbest I'll take care of that in future contributions. 😅 |
This probably would have failed on the TKO side if the TKO required those trailing spaces to be fixed (if I'm reading that correctly). I wouldn't base where to place pull requests based on those guidelines. @brianmhunt: if it's technically knockout, shouldn't that apply to these sorts of test considerations as well? |
Yes, we will have an eslint test on checking for the tko family of packages too at some point. :) |
Prefer <template> tags over jQuery for setHtml.
This PR documents
ko.utils.parseHtmlFragment
andko.utils.setHtml
.