feat: new experience to get coverage report #1785

AkashKumar7902 · 2024-04-06T13:32:06Z

Related Issue

Closes: #1735

Describe the changes you've made

Add coverage data to test report
coverage data will be appended for applications written in:

golang
node
python
java

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Code style update (formatting, local variables)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write `NA` if there isn't)

A clear and concise description of it.

Checklist:

My code follows the style guidelines of this project.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original	Updated
original screenshot	updated screenshot

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

pkg/service/tools/coverage.go

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

pkg/service/tools/coverage.go

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

…nge NYC_CLEAN to CLEAN Signed-off-by: Akash Kumar <meakash7902@gmail.com>

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

…nction Signed-off-by: Akash Kumar <meakash7902@gmail.com>

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

charankamarapu

Please address the comments, I haven't yet reviewed complete logic but these are the initial comments.

cli/provider/cmd.go

pkg/graph/schema.resolvers.go

pkg/service/replay/replay.go

pkg/service/tools/coverage.go

charankamarapu · 2024-05-20T12:37:20Z

Please resolve the pipeline failure too.

> move coverage.go from tools to service/replay pkg > define enum for language flag > refactored code Signed-off-by: Akash Kumar <meakash7902@gmail.com>

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

charankamarapu

Please address the comments

cli/provider/cmd.go

cli/test.go

pkg/service/replay/replay.go

pkg/service/replay/utils.go

> change error logs of coverage related tasks to warn, and error logs of coverage tool to debug > refactor > don't change command instead created a new field in config struct named CoverageCommand in which command prepended with coverage tool is put > log error if language detected doesn't match with language provided Signed-off-by: Akash Kumar <meakash7902@gmail.com>

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

charankamarapu

Please address the comments. Everything else looks good to me.

cli/provider/cmd.go

pkg/service/replay/replay.go

pkg/service/replay/utils.go

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

feat: add coverage data for go in report

de85b50

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

AkashKumar7902 marked this pull request as draft April 6, 2024 13:32

AkashKumar7902 added 7 commits April 6, 2024 22:50

feat: add coverage data in report in case of python

a416b23

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

feat: fix golint error

4555c84

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

fix: golint issue

c80852a

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

fix: golint error

7144ab6

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

feat: add typescript code coverage to report

de16718

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

feat: complete typescript coverage update in report

28c5a8a

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

fix: build

c9b04ba

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

AkashKumar7902 changed the title ~~feat: add coverage data for go in report~~ feat: add coverage data in report Apr 7, 2024

AkashKumar7902 added 2 commits April 11, 2024 00:51

feat: add coverage data to report in case of java application

7765a1d

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

feat: add jacoco go package in go.mod

cec7ffa

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

AkashKumar7902 marked this pull request as ready for review April 10, 2024 19:22

Merge branch 'main' into add-coverage-data-to-report

905f7c5

github-advanced-security bot found potential problems Apr 10, 2024

View reviewed changes

pkg/service/tools/coverage.go Fixed Show fixed Hide fixed

AkashKumar7902 added 2 commits April 11, 2024 01:00

fix: linter issue

dbc5b04

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

fix: golint issue

be98367

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

github-advanced-security bot found potential problems Apr 10, 2024

View reviewed changes

pkg/service/tools/coverage.go Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Apr 10, 2024

View reviewed changes

pkg/service/tools/coverage.go Fixed Show fixed Hide fixed

AkashKumar7902 and others added 11 commits April 15, 2024 13:27

fix: coverage percentage

810e9ce

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

Merge branch 'main' into add-coverage-data-to-report

bc562d2

feat: remove sdk (python, typescript)

c0c6fb3

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

finalize typescript coverage

b71ac6e

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

fix: remove unused functions

ca18f92

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

fix: remove unused dependency

89b7266

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

fix: remove goCoverage flag in favour of single coverage flag and cha…

5b168d3

…nge NYC_CLEAN to CLEAN Signed-off-by: Akash Kumar <meakash7902@gmail.com>

fix: change NYC_CLEAN to CLEAN env

83d3de1

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

fix: go coverage issue

3f42936

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

append coverage tool commands to app cmd

f74e514

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

add coveragerc file in cur dir

5242037

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

AkashKumar7902 added 2 commits May 20, 2024 12:59

append jacoco path to cmd and wrote downloadAndExtractJacocoBinary fu…

c945888

…nction Signed-off-by: Akash Kumar <meakash7902@gmail.com>

add merge and report of jacoco

450052a

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

AkashKumar7902 force-pushed the add-coverage-data-to-report branch from bb312ab to 450052a Compare May 20, 2024 10:10

AkashKumar7902 and others added 4 commits May 20, 2024 15:41

Merge branch 'main' into add-coverage-data-to-report

f10bb7c

change html report dir path

e82c796

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

calculate java coverage and insert report based on csv file

a6a0741

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

handle error in case of atoi and prepend packagename in class

a46cfe5

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

charankamarapu reviewed May 20, 2024

View reviewed changes

AkashKumar7902 added 4 commits May 22, 2024 20:40

address review comments:

a350abf

> move coverage.go from tools to service/replay pkg > define enum for language flag > refactored code Signed-off-by: Akash Kumar <meakash7902@gmail.com>

remove graph package

c61d75a

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

fix: wrap merge and generate jacoco report in if condition

3e8f35c

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

give more informative log when go binary is not built with cover flag

9d78662

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

charankamarapu reviewed May 27, 2024

View reviewed changes

AkashKumar7902 and others added 11 commits May 27, 2024 15:56

Merge branch 'main' into add-coverage-data-to-report

c877379

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

resolve warning

d917ebf

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

change env variable error logs to warn

f00f256

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

refactor: take merge and generate code to separate function

f3204bd

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

Merge branch 'main' into add-coverage-data-to-report

f647680

fix pipeline failure

420504e

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

populate coveragecommand with command

1cbfda5

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

Merge branch 'main' into add-coverage-data-to-report

42bec0c

fix linter issue

6a6a789

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

fix linter issue

3e00bf5

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

AkashKumar7902 force-pushed the add-coverage-data-to-report branch from 9709f93 to 3e00bf5 Compare May 29, 2024 11:56

Merge branch 'main' into add-coverage-data-to-report

1806ab7

charankamarapu reviewed Jun 3, 2024

View reviewed changes

cli/provider/cmd.go Outdated Show resolved Hide resolved

cli/provider/cmd.go Outdated Show resolved Hide resolved

pkg/service/replay/replay.go Show resolved Hide resolved

pkg/service/replay/utils.go Show resolved Hide resolved

AkashKumar7902 and others added 2 commits June 4, 2024 11:17

address review comments

771e41f

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

Merge branch 'main' into add-coverage-data-to-report

5e26bf0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new experience to get coverage report #1785

feat: new experience to get coverage report #1785

AkashKumar7902 commented Apr 6, 2024 •

edited

charankamarapu left a comment

charankamarapu commented May 20, 2024 •

edited

charankamarapu left a comment

charankamarapu left a comment

feat: new experience to get coverage report #1785

Are you sure you want to change the base?

feat: new experience to get coverage report #1785

Conversation

AkashKumar7902 commented Apr 6, 2024 • edited

Related Issue

Describe the changes you've made

Type of change

Please let us know if any test cases are added

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

Checklist:

Screenshots (if any)

charankamarapu left a comment

Choose a reason for hiding this comment

charankamarapu commented May 20, 2024 • edited

charankamarapu left a comment

Choose a reason for hiding this comment

charankamarapu left a comment

Choose a reason for hiding this comment

AkashKumar7902 commented Apr 6, 2024 •

edited

Describe if there is any unusual behaviour of your code(Write `NA` if there isn't)

charankamarapu commented May 20, 2024 •

edited