logging the login information from both API and saml. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jin-Sun-tts
force-pushed
the
logging-both-API-and-saml-login-info
branch
3 times, most recently
from
05c0f71
to
0d9f739
Compare
fix the lint from test_helpers file
nickumia-reisys
force-pushed
the
logging-both-API-and-saml-login-info
branch
2 times, most recently
from
d349f68
to
fc68df2
Compare
In CKAN 2.9, the user is not defined before login, so the userobj is not instantiated (hence the attributeerror) test: g has userobj, is it 2.9 and 2.10 compatible? test: is userobj not defined before login?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends identify() in IAuthenticator
We log user login information from both API and saml calls. and removed the log just for saml login.