Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent HTML overflow, fix #10647 #10735

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

fwiep
Copy link
Contributor

@fwiep fwiep commented May 11, 2024

Long lines of HTML are not wrapped, but overflow off the printed page.
This modification fixes this issue (#10647).

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey
Copy link
Member

droidmonkey commented May 11, 2024

Any other improvements you want to make while we are here? Perhaps we need to export PassKeys into a meaningful format.

@fwiep
Copy link
Contributor Author

fwiep commented May 12, 2024

Perhaps we need to export PassKeys into a meaningful format.

Hmm... There seems to be a considerable amount of discussion around this topic. Some people (including myself) want a paper backup of simply everything in their database. Others say exporting passkeys to clear text defeats their purpose, because they have to be plaintext along the way, somewhere.

Both, I think, are valid arguments.

In this case, however, as we're exporting all secrets anyway, let's include the passkeys too.

To be honest, I had not expected to have my pull request reviewed so quickly :). And my edit was pure CSS, not C++ or other actual code. I don't have much experience outside web development. But I will give it a go and learn along the way.

Kind regards,
FWieP

@droidmonkey
Copy link
Member

Gotcha, didn't know your skill level. If you aren't comfortable then don't worry we can do it. We are on the side of: it's your data, you are in control.

@droidmonkey droidmonkey modified the milestones: v2.8.0, v2.7.9 May 22, 2024
@droidmonkey droidmonkey merged commit c93eacd into keepassxreboot:develop May 27, 2024
11 checks passed
@fwiep fwiep deleted the patch-1 branch May 27, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants