Fix Flatpak config issues #10688
Merged
Fix Flatpak config issues #10688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove #ifdef guards from Config.h/cpp (no harm to non-Flatpak distros) Cleanup #ifdef usage in NixUtils.cpp
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10688 +/- ##
===========================================
- Coverage 63.67% 63.67% -0.00%
===========================================
Files 360 360
Lines 44228 44227 -1
===========================================
- Hits 28161 28160 -1
Misses 16067 16067 ☔ View full report in Codecov by Sentry. |
phoerious
approved these changes
May 7, 2024
|
We detect startup launch configurations to mark the setting enabled. That doesn't seem possible with flatpak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove #ifdef guards from Config.h/cpp (no harm to non-Flatpak distros, this config variable is ignored)
Cleanup #ifdef usage in NixUtils.cpp
Testing strategy
I am still trying to determine if this code actually works. It did not work with the test deploy of the flatpak via flathub. Waiting for prod deploy to test further.
Type of change