ci: rootless ci cd, sudo less github-runner #9633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvonkok
force-pushed
the
rootless-ci-cd
branch
2 times, most recently
from
37b486e
to
28a11b1
Compare
zvonkok
changed the title
zvonkok
force-pushed
the
rootless-ci-cd
branch
3 times, most recently
from
2a27605
to
60090dc
Compare
Add all modifications to do rootless ci/cd, sudo less github-runner Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
fidencio
reviewed
May 14, 2024
| @@ -1148,7 +1148,9 @@ silent_mode_error_trap() { | |||
| } | |||
|
|
|||
| main() { | |||
| git config --global --add safe.directory ${repo_root_dir} | |||
| #git config --global --add safe.directory ${repo_root_dir} | |||
fidencio
reviewed
May 14, 2024
| @@ -25,7 +25,7 @@ arch=$(uname -m) | |||
| [ "$arch" = "x86_64" ] && arch="amd64" | |||
| IMAGE_TAG="${REGISTRY}:kata-containers-$(git rev-parse HEAD)-${arch}" | |||
|
|
|||
| sudo chown -R $USER $HOME/.docker | |||
| #chown -R $USER $HOME/.docker | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need updates on the github actions as well. We need/can eliminate most of the
sudocommands.The main issue is that all targets are built with
sudoprivileges akarootandbuilddiranddestdirmay have a mix of$USERandrootowned files. That's why we havesudosprinkled all around.Additionally the
kata-static-$(target-build).xzare also owned byrootand that's why we're doingsudo oras.With these patches all build files in
builddiranddestdirare owned by the$USERand not root anymore.I have a github-runner without
sudoprivileges running. Here is an example of a simplified run: https://github.com/zvonkok/kata-containers/actions/runs/9082982416/job/24961219629?pr=14