Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unuse ghaction step and collect logs of karmadactl test. #4824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liangyuanpeng
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
/kind cleanup

this CI is using the kubernetes from created by cli-testing-environment and have not used helm/kind-action, so juse remove it..

hack/create-cluster.sh ${HOST_CLUSTER_NAME} ${KUBECONFIG_PATH}/${HOST_CLUSTER_NAME}.config > /dev/null 2>&1 &
hack/create-cluster.sh ${MEMBER_CLUSTER_1_NAME} ${KUBECONFIG_PATH}/${MEMBER_CLUSTER_1_NAME}.config > /dev/null 2>&1 &
hack/create-cluster.sh ${MEMBER_CLUSTER_2_NAME} ${KUBECONFIG_PATH}/${MEMBER_CLUSTER_2_NAME}.config > /dev/null 2>&1 &

the second change is collect logs for kind kubernetes.

/assign @RainbowMango

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 10, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 10, 2024
@RainbowMango
Copy link
Member

@zhzhuang-zju Please take a look

@zhzhuang-zju
Copy link
Contributor

/assign

# Only upload logs on failure.
if: ${{ failure() }}
- name: export logs
if: always()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to collect logs when workflow succeeds or is canceled as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it can be treated the same as CI,

- name: upload logs
if: always()
uses: actions/upload-artifact@v3

.github/workflows/cli.yaml Outdated Show resolved Hide resolved
@zhzhuang-zju
Copy link
Contributor

@liangyuanpeng This PR consists of two parts actually as you mentioned in the PR description:

  • remove step helm/kind-action
    Just as you said, this CI is using the kubernetes from created by cli-testing-environment, so step kind-action can be removed. But I have two questions.
    1. When was kind installed on the environment, I don't find anywhere in cli-testing-environment where kind is installed, am I missing it?
    2. How did you find this? I mean, "kind-action" isn't used, but it shouldn't have an effect on workflow and is hard to detect.
  • collect logs for kind kubernetes
    I‘m okay with this part.

BTW, thanks for this commit~

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Apr 11, 2024

When was kind installed on the environment, I don't find anywhere in cli-testing-environment where kind is installed, am I missing it?

Good catch! seems like it's provided by github action or some github action cache. i will update the cli-testing-environment.sh to check and install the command of kind.

How did you find this? I mean, "kind-action" isn't used, but it shouldn't have an effect on workflow and is hard to detect.

I am wroting the code for #4801 and I was not satisfied with the workflow. He increased the number of parallel runs of the action, so i more research this workflow and found it.

@zhzhuang-zju

@liangyuanpeng
Copy link
Contributor Author

In the next PR, I will continue to update this workflow, use one action to build the image and karmadactl, and then test it in other actions, CI workflow is the same thing, and let's talk about it in other space.

@zhzhuang-zju
Copy link
Contributor

use one action to build the image and karmadactl

There seems to have been a discussion about it before,#3168 (comment) @RainbowMango

In the next PR, I will continue to update this workflow

Very welcome. If you make any progress, please ping me~

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from rainbowmango after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants