Update to version 4.0.0 with Python3 support #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Python3, tested against 3.7 and 3.9 but should work with any 3.x version. Support for Python 2.x versions is dropped completely. Updated to use SqlAlchemy 1.4 the current version installed via pip, and switches the XML library from the old PyXML to lxml for xpath.
Currently it is possible to start the service with the internal development web server and somethings work. Guest creation is broken due to some input validation errors and one of the drop down menus not populating. Network storage support is broken because the iscsi commands can't be run by pysilhouette because of permissions. I'm exploring was to give the pysilhouette user account permissions without just running it as root, until then network storage will remain broken.
Once the service is completely functional again I will update the documentation.