Config rework #2108
Draft
Config rework #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh I also added a |
|
I couldn't run all specs locally. There are a couple that failed where I changed the spec. In particular, it was testing that if it set |
mensfeld
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't finished yet. The idea here is to use
:not_givenas all config parameters, construct the config proactively, and only consider it a "read" operation if no parameters are given at all.periodic_job is a bit more in-depth, so I'm leaving off on it for now - I just wanted to validate this approach first and get feedback. Also not sure if there's additional configuration I'm not aware of, I was looking at the topic stuff.
The main advantage here is the ability to make changes to individual parts of each config rather than blowing away the whole thing at once. It also opens up the ability to redefine / reconfigure things dynamically if needed - right now, you can only configure any feature once, either by explicit setting or by default, and never again.
@mensfeld