-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(router): added a new type minor unit to amount #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/juspay/hyperswitch into change_core_amount_to_domain_type
sahkal
added
A-core
Area: Core flows
C-refactor
Category: Refactor
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
May 13, 2024
…m/juspay/hyperswitch into change_core_amount_to_domain_type
jarnura
reviewed
May 14, 2024
jarnura
previously approved these changes
May 15, 2024
…m/juspay/hyperswitch into change_core_amount_to_domain_type
jarnura
previously approved these changes
May 20, 2024
): fixed open api specs
jarnura
approved these changes
May 20, 2024
Narayanbhat166
approved these changes
May 20, 2024
vspecky
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on behalf of @juspay/hyperswitch-routing
hrithikesh026
approved these changes
May 21, 2024
@@ -75,7 +75,7 @@ impl<F: Send + Clone> | |||
})? | |||
} | |||
|
|||
if request.amount < payment_intent.amount { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this needed?
SamraatBansal
approved these changes
May 21, 2024
apoorvdixit88
approved these changes
May 21, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently we have amount as i64 value, everywhere but we want it to be inside some Unit struct stating its denomination type. With this change we are adding MinorUnit as a new type which will flow through all core flows, and will send this type to connectors in upcoming pr's
Additional Changes
Motivation and Context
How did you test it?
Flows to be tested
Checklist
cargo +nightly fmt --all
cargo clippy