-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: email templates updated #4562
base: main
Are you sure you want to change the base?
Conversation
@@ -76,7 +76,7 @@ pub mod html { | |||
EmailBody::MagicLink { link, user_name } => { | |||
format!( | |||
include_str!("assets/magic_link.html"), | |||
user_name = user_name, | |||
username = user_name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To maintain the consistency, as in other emails, if you see, we use username for html files and user_name is what we are assigning to username. No other reason. Hence utilised "username" in the Magiclink.html file where it was required rather than user_name.
I don't think so head tag is required just check once it was previously working. |
<td> | ||
Hi {username}, You have received this email because your | ||
administrator has invited you as a new user on | ||
Hyperswitch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes we are using Hyperswitch
and sometimes HyperSwitch
. Can we make this consistent.
> | ||
<tr> | ||
<td> | ||
Hi {username}, You have received this email because your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi {username}, You have received this email because your | |
Hi {username}, you have received this email because your |
> | ||
<tr> | ||
<td> | ||
Dear {username}, We are thrilled to welcome you into our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear {username}, We are thrilled to welcome you into our | |
Dear {username}, we are thrilled to welcome you into our |
> | ||
<tr> | ||
<td> | ||
This link provides instant access to hyperswitch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link provides instant access to hyperswitch | |
This link provides instant access to Hyperswitch |
</li> | ||
<li>Click on the "Login" button.</li> | ||
<li>Enter your login credentials to log in.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li>Enter your login credentials to log in.</li> | |
<li>Enter your login credentials.</li> |
Create and link an issue. |
Type of Change
Description
Updated the HTML templates to new designs in backend
Look at the below screenshots
Old
New
Additional Changes
Motivation and Context
How did you test it?
Please find below curls for same :
curl --location 'http://localhost:8080/user/connect_account'
--header 'Content-Type: application/json'
--data-raw '{
"email": "gitanjli524@gmail.com"
}'
curl --location 'http://localhost:8080/user/user/invite_multiple?is_token_only=true'
--header 'Content-Type: application/json'
--header 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiNGMyMjUyMTktZGVjNC00M2VlLTgyOTktMTBjMDRmYzkxYWYzIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzA2ODY5OTYzIiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTcxNjk4MTMwNSwib3JnX2lkIjoib3JnX2dMbEJuQzgwVTgxNzlVTnozdm5sIn0.JsZr4aSFm_2C8si9byvS02kIAaYvpNNF_xidZSRm1sU'
--header 'Cookie: login_token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiNGMyMjUyMTktZGVjNC00M2VlLTgyOTktMTBjMDRmYzkxYWYzIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzA2ODY5OTYzIiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTcxNjk4MTMwNSwib3JnX2lkIjoib3JnX2dMbEJuQzgwVTgxNzlVTnozdm5sIn0.JsZr4aSFm_2C8si9byvS02kIAaYvpNNF_xidZSRm1sU'
--data-raw '[
{
"email": "gitanjli524+098763@gmail.com",
"name": "25",
"role_id": "merchant_view_only"
}
]'
curl --location 'http://localhost:8080/user/forgot_password'
--header 'Content-Type: application/json'
--header 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiZDM2NzMyMTUtYWU3NS00NGMzLWJiYzEtMGY3YmMxYmYwMjdmIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzEyMjE0NDE5Iiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTcxMjM4NzMyOSwib3JnX2lkIjoib3JnXzhLb2lWNmhrcG9KSGZNcllER1ZhIn0.H2G9oGp_JBoz3k5S7fMvaaJ9T0cG5VtUjM0hU3ltM3g'
--data-raw '{
"email": "gitanjli524@gmail.com"
}'
Checklist
cargo +nightly fmt --all
cargo clippy