-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a signal to proxy all Completer.selected
signals
#16312
Conversation
Completer currently emits a signal when a completion is selected. This surfaces that signal to the CompletionProviderManager, which then proxies all the Completer signals to the new signal. This will allow extensions to know when a selection is made in a Completer. Currently there are edge cases where a selection can be made without calling a command that can be connected to. Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
Thanks for making a pull request to jupyterlab! |
@krassowski here's my implementation I pitched in #16294 based on your idea:
I'm still open to other solutions, but figured I would implement and submit this PR since it was pretty easy to do so. I've also tested that it does solve my problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ajbozarth!
Completer.selected
signals
References
Fixes #16294
Code changes
Completer
currently emits a signal (_selected
) when a completion is selected. This PR creates a new signal inCompletionProviderManager
, which proxies theCompleter
signal from everyCompletionHandler
that is generated.This will allow extensions to know when a selection is made by any Completer. Currently there are edge cases (as listed in #16294) where a selection can be made without calling a command that can be connected to.