Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add full URLs to share models #4817

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented May 14, 2024

  • full_url for SharedServer
  • full_accept_url for ShareCode

same as #4798, applied to shares

- full_url for SharedServer
- full_accept_url for ShareCode
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, but I've not tested this or similar.

@minrk minrk changed the title add full URLs to share modes add full URLs to share models May 16, 2024
@minrk minrk merged commit 6912a5a into jupyterhub:main May 16, 2024
21 checks passed
@minrk minrk deleted the share-code-full-url branch May 16, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants