-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: simplify api docs generation for comparison #4253
base: main
Are you sure you want to change the base?
docs: simplify api docs generation for comparison #4253
Conversation
consideRatio
commented
Dec 7, 2022
•
edited
edited
- PR created as a comparative reference for discussion in docs: classes generated docs sometimes include non-traits members, and sometimes do #4252
.. autoconfigurable:: Spawner | ||
:members: options_from_form, poll, start, stop, get_args, get_env, get_state, template_namespace, format_string, create_certs, move_certs | ||
:members: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. autoconfigurable:: LocalProcessSpawner | ||
:members: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. autoclass:: User | ||
:members: escaped_name | ||
|
||
.. attribute:: name | ||
|
||
The user's name | ||
|
||
.. attribute:: server | ||
|
||
The user's Server data object if running, None otherwise. | ||
Has ``ip``, ``port`` attributes. | ||
|
||
.. attribute:: spawner | ||
|
||
The user's :class:`~.Spawner` instance. | ||
:members: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. autoconfigurable:: Service | ||
:members: name, admin, url, api_token, managed, kind, command, cwd, environment, user, oauth_client_id, server, prefix, proxy_spec | ||
:members: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. autoconfigurable:: ConfigurableHTTPProxy | ||
:members: debug, auth_token, check_running_interval, api_url, command | ||
:members: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. autoconfigurable:: DummyAuthenticator | ||
:members: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. autoconfigurable:: PAMAuthenticator | ||
:members: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I think we probably should use Part of this is that I haven't been careful about prefixing private APIs with Service has no API because no extension APIs have handles on them, so those API docs are purely for jupyterhub contributor reference. |
After thinking a bit about this, I think we mostly don't want I think User is probably the class where I've done the most "accidental public API" by exposing attributes that shouldn't be public without a I think maybe even Spawner and Authenticator should occur in two separate places: one config-only for deployers, and one with public API methods for developers. Because implementation details can be very distracting for someone looking for a configuration reference. WDYT? |