Doc fix #4200
Open
Doc fix #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
added
documentation
outreachy-dec22
minrk
reviewed
Nov 24, 2022
| @@ -39,24 +39,24 @@ multiple processes which might try to access the file at the same time. | |||
| ### PostgreSQL | |||
|
|
|||
| We recommend using PostgreSQL for production if you are unsure whether to use | |||
| MySQL or PostgreSQL or if you do not have a strong preference. There is | |||
| MySQL or PostgreSQL or if you do not have a strong preference. This is because there is an | |||
There was a problem hiding this comment.
This isn't the reason, it's another (related) fact.
Suggested change
| MySQL or PostgreSQL or if you do not have a strong preference. This is because there is an | |
| MySQL or PostgreSQL or if you do not have a strong preference. There is |
| @@ -9,7 +9,7 @@ The default database for JupyterHub is a [SQLite](https://sqlite.org) database. | |||
| We have chosen SQLite as JupyterHub's default for its lightweight simplicity | |||
| in certain uses such as testing, small deployments and workshops. | |||
|
|
|||
| For production systems, SQLite has some disadvantages when used with JupyterHub: | |||
| For production systems, SQLite has some disadvantages when used with JupyterHub which includes: | |||
There was a problem hiding this comment.
Suggested change
| For production systems, SQLite has some disadvantages when used with JupyterHub which includes: | |
| For production systems, SQLite has some disadvantages when used with JupyterHub, including: |
| connections serverside if they've been idle for a while, and the connection | ||
| from the hub will be idle for longer than most connections. This behavior | ||
| will lead to frustrating 'the connection has gone away' errors from | ||
| which depends on your MySQL setup. This is necessary since MySQL kills serverside |
There was a problem hiding this comment.
Suggested change
| which depends on your MySQL setup. This is necessary since MySQL kills serverside | |
| which depends on your MySQL setup. This is necessary since MySQL kills server-side |
| sqlalchemy if `pool_recycle` is not set. | ||
| - If you use `utf8mb4` collation with MySQL earlier than 5.7.7 or MariaDB | ||
| earlier than 10.2.1 you may get an `1709, Index column size too large` error. | ||
| To fix this you need to set `innodb_large_prefix` to enabled and | ||
| `innodb_file_format` to `Barracuda` to allow for the index sizes jupyterhub | ||
| uses. `row_format` will be set to `DYNAMIC` as long as those options are set | ||
| uses, `row_format` will be set to `DYNAMIC` as long as those options are set |
There was a problem hiding this comment.
Ending a sentence here is correct:
Suggested change
| uses, `row_format` will be set to `DYNAMIC` as long as those options are set | |
| uses. `row_format` will be set to `DYNAMIC` as long as those options are set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rephrased the parts of the docs on database.