-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Layout of the JupyterHub repository #4066
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Temidayo32, I think this is useful!
I think when I mentioned a layout of the repo in jupyterhub/team-compass#296 (comment) I was referring to how the code (within jupyterhub/
is organized (e.g. orm.py
contains the database code, the REST API is in jupyterhub/apihandlers
, etc.), but this is still useful.
@choldgraf @willingc what do you think is the right level of detail to describe "all the files" of a single repo? I don't see this very often in repo docs.
docs/source/contributing/layout.rst
Outdated
This file provides information on how to report an identified security vulnerability in the JupyterHub project. | ||
|
||
|
||
dotfiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotfiles aren't a separate category - these are mostly the same as what's called 'executable files' right now. Some of them just happen to start with '.'
I think the main thing to consider is whether this will be kept up to date. @willingc suggested a top-level If we keep it as RST then how about hyperlinking the files docs to the |
@manics Yeah, that is a good observation. I would think if kept high level enough, then updating needs would be minimal. The documentation would go through a major revamp on the completion of the Outreachy intern. This could mean a major modification of the files in the docs directory. However, if the layout is kept just describing the docs folder and not going indepth to describe its sub-folder, then the modification that would take place would not require an updating of the Layout |
7bd4344
to
828d5be
Compare
@choldgraf raised an issue #3080 on the need for a documentation that provides a layout of the Jupyterhub repository. This pull request addresses the issue. Please, let me know of any further corrections to the made.
I am also an Outreachy intern. This effectively serves as my first contribution to the project during this contribution period.