Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test on mobile #7371

Closed
wants to merge 1 commit into from
Closed

Conversation

brichet
Copy link
Contributor

@brichet brichet commented May 15, 2024

Wait for the opener button to be visible in notebook toolbar.

Fixes #7370

Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/notebook/fix-test-mobile

@jtpio jtpio added this to the 7.2.x milestone May 15, 2024
@jtpio
Copy link
Member

jtpio commented May 15, 2024

Thanks @brichet for looking into this 👍

According to the Playwright test report, the toolbar button does not seem to be visible:

responsive-opener.webm

@brichet
Copy link
Contributor Author

brichet commented May 15, 2024

Yes, I saw that.
But I'm not able to reproduce it locally, the button always shows up when I test it...

@brichet
Copy link
Contributor Author

brichet commented May 15, 2024

But I'm not able to reproduce it locally, the button always shows up when I test it...

I finally managed to reproduce it locally, it seems there is again an issue with the toolbar, in this very specific case...

@jtpio
Copy link
Member

jtpio commented May 15, 2024

Is it also reproducible in JupyterLab?

@brichet
Copy link
Contributor Author

brichet commented May 15, 2024

Not that I know, but probably, it seems to be a computation issue related to the width.
I managed to reproduce it with a window width between 521px and 526px on first load.
Probably some other width ranges can be affected too, and it depends on the items displayed in the toolbar. For example, it works well with the same range if the interface-switcher is disabled.

@brichet
Copy link
Contributor Author

brichet commented May 15, 2024

After some more tests, it may be related to the debugger icon.
When the popup-opener doesn't show up, the debugger icon take its place in the DOM, with a width of 0px.

@jtpio
Copy link
Member

jtpio commented May 15, 2024

Ah so maybe it's related to #6731.

The motivation behind that change was to free some space in the notebook toolbar on mobile, also since the debugger is unlikely to be used on a small screen (although it can still be opened via the menu if needed).

@brichet
Copy link
Contributor Author

brichet commented May 15, 2024

Ah so maybe it's related to #6731.

Thanks for the link, I was confused about the behavior of this button, which only appeared when the window was wide... 😄

Indeed, I can't reproduce this issue without the rule added in #6731.
Let's close this PR and find another way to hide the button.

@brichet brichet closed this May 15, 2024
@brichet brichet mentioned this pull request May 15, 2024
@brichet brichet deleted the fix-test-mobile branch May 16, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky UI tests
2 participants