Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterLab 4.2.0b0 #7312

Merged
merged 9 commits into from
Apr 10, 2024
Merged

Update to JupyterLab 4.2.0b0 #7312

merged 9 commits into from
Apr 10, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 3, 2024

@jtpio jtpio added this to the 7.2.0 milestone Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Binder 👈 Launch a Binder on branch jtpio/notebook/update-lab-420b0

@jtpio
Copy link
Member Author

jtpio commented Apr 5, 2024

Now seeing the following error in the dev tools console, which seems related to jupyterlab/jupyterlab#14683 :

image

Co-Authored-By: v-lozko <156805389+v-lozko@users.noreply.github.com>
@jtpio
Copy link
Member Author

jtpio commented Apr 5, 2024

cc @afshin do you know what the main DOM differences are between the defer and full modes? Gonna look into updating the CSS to fix #7231.

For now the browser default scrollbar is still missing.

@jtpio jtpio marked this pull request as ready for review April 9, 2024 07:55
@krassowski
Copy link
Member

Default to defer for now

I think this is fine. There is less of a user benefit for Notebook than for Lab from using full windowed mode because users may have 10 long notebooks in Lab opened in a single browser tab, but not in Notebook.

@jtpio
Copy link
Member Author

jtpio commented Apr 9, 2024

Is there a way to set the windowing mode without going through the settings?

Otherwise this also changes the windowing mode used in JupyterLab (if notebook is opened), as the settings are shared between notebook and lab. There is a similar issue with Notebook setting the file browser checkboxes by default, which currently also show up in lab (jupyterlab/jupyterlab#14623).

@krassowski
Copy link
Member

It looks like you would need to override the notebookConfig in factory: https://github.com/jupyterlab/jupyterlab/blob/6152e3a5f94d728ccd2727d6d8413f12ddafb669/packages/notebook-extension/src/index.ts#L1867-L1898

An alternative would be to use setting transforms to change the default value temporarily.

@jtpio
Copy link
Member Author

jtpio commented Apr 9, 2024

An alternative would be to use setting transforms to change the default value temporarily.

Looks like that would mean using a setting transform for the @jupyterlab/notebook-extension:tracker plugin, which is the one defining the windowingMode? https://github.com/jupyterlab/jupyterlab/blob/6152e3a5f94d728ccd2727d6d8413f12ddafb669/packages/notebook-extension/schema/tracker.json#L816
But the setting file does not seem to have jupyter.lab.transform set to true.

@jtpio
Copy link
Member Author

jtpio commented Apr 10, 2024

Opened #7318 to have a look later to not block this PR.

If anyone would like to help with this or #7231 that would be appreciated, thanks!

@jtpio jtpio merged commit 2b9d339 into jupyter:main Apr 10, 2024
31 checks passed
@jtpio jtpio deleted the update-lab-420b0 branch April 10, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants